-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CMS custom hacks for Oracle OCCI old C++ ABI compatibility #25691
Remove CMS custom hacks for Oracle OCCI old C++ ABI compatibility #25691
Conversation
The code-checks are being triggered in jenkins. |
please test with cms-sw/cmsdist#4645 |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25691/8060
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @mrodozov (Mircho Rodozov) for master. It involves the following packages: CaloOnlineTools/HcalOnlineDb @ggovi, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-1 Tested at: 24a558d You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build
I found compilation error when building: >> Building shared library tmp/slc7_amd64_gcc700/src/OnlineDB/Oracle/src/OnlineDBOracle/libOnlineDBOracle.so Copying tmp/slc7_amd64_gcc700/src/OnlineDB/Oracle/src/OnlineDBOracle/libOnlineDBOracle.so to productstore area: Leaving library rule at OnlineDB/Oracle >> Compiling /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_5_DEVEL_X_2019-01-16-2300/src/OnlineDB/Oracle/test/test.cpp /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_5_DEVEL_X_2019-01-16-2300/src/OnlineDB/Oracle/test/test.cpp: In function 'int main(int, char**)': /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_5_DEVEL_X_2019-01-16-2300/src/OnlineDB/Oracle/test/test.cpp:31:34: error: 'getOraMessage' was not declared in this scope cout <<"Exception Message:"<> Building binary test_occi_std_length c++: error: tmp/slc7_amd64_gcc700/src/OnlineDB/Oracle/test/test_occi_std_length/test.cpp.o: No such file or directory |
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
please test with cms-sw/cmsdist#4645 |
The tests are being triggered in jenkins. |
-1 |
@smuzaffar is the error message related to the use of the DEVEL IB instead of the main one? |
Comparison job queued. |
@fabiocos , please ignore that error. Error was due to an update in cms-bot and this has been fixed and latest tests has anyway override the previous failure results. |
@fabiocos , I would like to merge this for DEVEL IB to run all tests. |
Comparison is ready Comparison Summary:
|
Removes custom oracle calls introduces in this commit
03499f0
and keeps the changes introduced in later commits.
Revert #22384 commit 03499f0