Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CMS custom hacks for Oracle OCCI old C++ ABI compatibility #25691

Merged

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Jan 17, 2019

Removes custom oracle calls introduces in this commit
03499f0
and keeps the changes introduced in later commits.

Revert #22384 commit 03499f0

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@mrodozov
Copy link
Contributor Author

please test with cms-sw/cmsdist#4645

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25691/8060

  • This PR adds an extra 88KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 17, 2019

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#4645
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32678/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

CaloOnlineTools/HcalOnlineDb
OnlineDB/CSCCondDB
OnlineDB/EcalCondDB
OnlineDB/SiStripConfigDb

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@erikbutz, @mmusich, @argiro this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Tested at: 24a558d

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25691/32678/summary.html

I found follow errors while testing this PR

Failed tests: Build

  • Build:

I found compilation error when building:

>> Building shared library tmp/slc7_amd64_gcc700/src/OnlineDB/Oracle/src/OnlineDBOracle/libOnlineDBOracle.so
Copying tmp/slc7_amd64_gcc700/src/OnlineDB/Oracle/src/OnlineDBOracle/libOnlineDBOracle.so to productstore area:
Leaving library rule at OnlineDB/Oracle
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_5_DEVEL_X_2019-01-16-2300/src/OnlineDB/Oracle/test/test.cpp 
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_5_DEVEL_X_2019-01-16-2300/src/OnlineDB/Oracle/test/test.cpp: In function 'int main(int, char**)':
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_5_DEVEL_X_2019-01-16-2300/src/OnlineDB/Oracle/test/test.cpp:31:34: error: 'getOraMessage' was not declared in this scope
     cout <<"Exception Message:"<> Building binary test_occi_std_length
c++: error: tmp/slc7_amd64_gcc700/src/OnlineDB/Oracle/test/test_occi_std_length/test.cpp.o: No such file or directory


@cmsbuild
Copy link
Contributor

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@smuzaffar smuzaffar changed the title Revert https://github.com/cms-sw/cmssw/pull/22384 commit 03499f00f52 Remove CMS custom hacks for Oracle OCCI old C++ ABI compatibility Jan 18, 2019
@smuzaffar smuzaffar changed the base branch from master to CMSSW_10_5_DEVEL_X January 21, 2019 08:45
@smuzaffar
Copy link
Contributor

please test with cms-sw/cmsdist#4645

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 21, 2019

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#4645
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32739/console

@cmsbuild
Copy link
Contributor

-1
Tested at: UNKNOWN
I was not able to find a release to test this PR. See the Jenkins logs for more details.

@fabiocos
Copy link
Contributor

@smuzaffar is the error message related to the use of the DEVEL IB instead of the main one?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@smuzaffar
Copy link
Contributor

@fabiocos , please ignore that error. Error was due to an update in cms-bot and this has been fixed and latest tests has anyway override the previous failure results.

@smuzaffar
Copy link
Contributor

@fabiocos , I would like to merge this for DEVEL IB to run all tests.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25691/32739/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 198 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3097440
  • DQMHistoTests: Total failures: 77
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3097166
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2019

backport done
Successfully backported PR #25691 as #26083 for branch master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants