-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate RawToDigi to Tasks #25162
Migrate RawToDigi to Tasks #25162
Conversation
Keeping sequences for to avoid massive migration.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25162/7161 |
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: Configuration/StandardSequences @perrotta, @cmsbuild, @civanch, @mdhildreth, @nsmith-, @rekovic, @franzoni, @thomreis, @slava77, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1
|
ping |
+1 |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+operations the modifications to the StandardSequences are coherent with the purpose of the PR. A run of 136.85 with the Tracer service enabled confirms that the list of executed modules in a typical Run2 workflow is unchanged. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
Title says it all. Supersedes #25110 by including a "Task" somewhere in the added task names, and keeping the sequences for "backwards" compatibility (to avoid a massive migration as in #25110). I did migrate three customize functions that replaced a module with a
Sequence
(because one can't add aSequence
to aTask
).Tested in CMSSW_10_4_X_2018-11-01-2300, no changes expected.