Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate RawToDigi to Tasks #25110

Closed
wants to merge 2 commits into from
Closed

Migrate RawToDigi to Tasks #25110

wants to merge 2 commits into from

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Nov 2, 2018

Title says it all. I migrated all downstream configurations I managed to find with git grep.

Workflows with generator filters need #25084 (which is already merged but not yet in an IB) in addition.

Tested in CMSSW_10_4_X_2018-11-01-2300, no changes expected.

@cmsbuild cmsbuild added this to the CMSSW_10_4_X milestone Nov 2, 2018
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2018

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25110/7103

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2018

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

Configuration/StandardSequences
DQM/Integration
DQM/SiPixelMonitorTrack
EventFilter/CTPPSRawToDigi
L1Trigger/Configuration
SimTracker/TrackHistory

@perrotta, @cmsbuild, @andrius-k, @kmaeshima, @schneiml, @civanch, @mdhildreth, @nsmith-, @rekovic, @franzoni, @jfernan2, @thomreis, @slava77, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@felicepantaleo, @forthommel, @HeinerTholen, @fioriNTU, @thomreis, @threus, @hdelanno, @imarches, @smoortga, @acaudron, @ferencek, @GiacomoSguazzoni, @rovere, @VinInn, @jandrea, @idebruyn, @ebrondol, @dgulhan, @Martin-Grunewald, @batinkov, @jan-kaspar, @JyothsnaKomaragiri, @mverzett, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

makortel commented Nov 2, 2018

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2018 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31450/console Started: 2018/11/02 18:36

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2018

-1

Tested at: cb98c33

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25110/31450/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
101.0 step1

runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2018

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@makortel
Copy link
Contributor Author

makortel commented Nov 2, 2018

@cmsbuild, please test with #25084

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2018

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25110/7143

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2018

Pull request #25110 was updated. @perrotta, @cmsbuild, @andrius-k, @kmaeshima, @schneiml, @civanch, @mdhildreth, @nsmith-, @rekovic, @franzoni, @jfernan2, @kpedro88, @thomreis, @slava77, @fabiocos, @davidlange6 can you please check and sign again.

@makortel
Copy link
Contributor Author

makortel commented Nov 6, 2018

@cmsbuild, please test

I found out that my earlier downstream migration was not complete (sorry about that), so here is a new attempt (still with git grep).

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2018 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31508/console Started: 2018/11/06 21:30

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2018

+1
Tested at: f2f8390
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25110/31508/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25110/31508/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2993155
  • DQMHistoTests: Total failures: 242
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2992716
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.281 KiB( 31 files compared)
  • DQMHistoSizes: changed ( 7.3 ): -0.141 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 7.3 ): -0.141 KiB MessageLogger/Errors
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@andrius-k
Copy link

+1

@makortel makortel mentioned this pull request Nov 7, 2018
Closed
kpedro88
kpedro88 reviewed Nov 8, 2018
View reviewed changes
SimMuon/RPCDigitizer/python/rpcChamberMasker_cff.py
+ process.muonRPCDigis)
process.RawToDigi.replace(process.muonRPCDigis, \
process.filteredRPCDigiSequence)
process.filteredRPCDigiTask = cms.task(process.preRPCDigis,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uppercase Task?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kevin (and actually all this can be replaced with RawToDigi.add(process.preRPCDigis), which I did in #25162).

@makortel makortel mentioned this pull request Nov 8, 2018
Merged
@makortel
Copy link
Contributor Author

makortel commented Nov 8, 2018 •
edited
Loading

Closing in favor of #25162 (that avoids a massive migration, sorry for the noise).

@makortel makortel closed this Nov 8, 2018
@makortel makortel mentioned this pull request Nov 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpedro88 kpedro88 kpedro88 left review comments

Assignees
No one assigned
Labels
code-checks-approved comparison-available dqm-approved l1-pending operations-pending orp-pending pending-signatures reconstruction-pending simulation-pending tests-approved upgrade-pending
Projects
None yet
Milestone
CMSSW_10_4_X
Development

Successfully merging this pull request may close these issues.
7 participants
@makortel @cmsbuild @slava77 @civanch @andrius-k @thomreis @kpedro88