JME python configuration cleanup for 92x #19222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…), lower L1 cluster threshold
The channel() should only return the encoded channel, not the otbit. Indeed, channel() is used all over the place in the MC matching code to access the position. As a consequence, channel() and packedPosition() now do the same.
…into a few master config files, move customization into RecoJets/JetProducers since nothing is non-standard in RECO at all anymore.
…o be picked up automatically by the GUI. 2) reportSummary ME added to EventInfo directory. The mean value of the bins the reportSummaryMap. 3) Moved roc counting plots to PixelPhase1/ directory.
|
Grrr. something went wrong with git. I will rebase. |
cmsbuild
added
alca-pending
comparison-pending
core-pending
daq-pending
db-pending
dqm-pending
generators-pending
geometry-pending
hlt-pending
l1-pending
operations-pending
pdmv-pending
simulation-pending
tests-pending
upgrade-pending
visualization-pending
and removed
comparison-available
tests-approved
labels
|
Pull request #19222 was updated. @ghellwig, @perrozzi, @ianna, @kpedro88, @fabozzi, @Martin-Grunewald, @mommsen, @vanbesien, @govoni, @perrotta, @civanch, @monttj, @silviodonato, @cmsbuild, @fwyzard, @GurpreetSinghChahal, @davidlange6, @smuzaffar, @Dr15Jones, @kkousour, @mdhildreth, @cerminar, @slava77, @ggovi, @mulhearn, @vazzolini, @rekovic, @kmaeshima, @arunhep, @emeschi, @thuer, @dmitrijus, @alja, @franzoni can you please check and sign again. |
|
I can't seem to fix the git problems, I will close this PR and reopen a new one. |
|
@rappoccio in the future please follow http://cms-sw.github.io/tutorial-resolve-conflicts.html |
|
Thanks, this is helpful. |
cmsbuild
added a commit
that referenced
this pull request
Jun 30, 2017
Rebase of #19222: JME python configuration cleanup for 92x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JME python configurations had many vestiges left of previous migrations, as well as considerable "top-level" customization that is no longer relevant. I have consolidated the RecoPFJets_cff customizations into separate cfi python files in RecoJets/JetProducers.
EDIT: No changes should occur to any output, this is a reorganization.