-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pixelTracks imports #17470
Fix pixelTracks imports #17470
Conversation
@cmsbuild, please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_9_0_X. It involves the following packages: RecoPixelVertexing/PixelTrackFitting @perrotta, @cmsbuild, @silviodonato, @cvuosalo, @fwyzard, @Martin-Grunewald, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
Comparison job queued. |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
+1 |
This PR is a follow-up to #17438 adding a
pixelTracks_cfi
that imports from descriptions-generatedpixelTracksDefault_cfi
, and changing all affected files to import from `pixelTracks_cfi. This should have been done already in #17170, but somehow I missed it.The
PixelTracksL2Tau_cfi
(*) referencedTrackingRegionsFromBeamSpotAndL2Tau
(in pre-#17170 way), so I addedTrackingRegionsFromBeamSpotAndL2TauEDProducer
to produce theTrackingRegion
s to event as required by the new seeding framework. I'm not sure how usefulPixelTracksL2Tau_cfi
is anymore though, as now it has just a clone ofPixelTracksProducer
and aTrackingRegionsFromBeamSpotAndL2TauEDProducer
module via import (i.e. hit doublet/triplet/quadruplet producers and filter+fitter+cleaner are missing).(*) I guess this is being used for ConfDB parsing since it was modified in #17438.
Tested in 9_0_0_pre3, no changes expected.
@rovere @VinInn @Martin-Grunewald