-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup (following #17098) for HLT ConfDB parsing #17438
Cleanup (following #17098) for HLT ConfDB parsing #17438
Conversation
A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_9_0_X. It involves the following packages: RecoTracker/DeDx @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
please test |
The tests are being triggered in jenkins. |
type bugfix |
Pull request #17438 was updated. @perrotta, @cmsbuild, @silviodonato, @cvuosalo, @fwyzard, @Martin-Grunewald, @slava77, @davidlange6 can you please check and sign again. |
please abort |
@@ -12,7 +12,7 @@ | |||
pixelTTRHBuilderWithoutAngle = copy.deepcopy(ttrhbwr) | |||
from RecoTracker.TkSeedingLayers.TTRHBuilderWithoutAngle4PixelTriplets_cfi import * | |||
from RecoTracker.TkSeedingLayers.PixelLayerTriplets_cfi import * | |||
from RecoPixelVertexing.PixelTrackFitting.PixelTracks_cfi import * | |||
from RecoPixelVertexing.PixelTrackFitting.pixelTracksDefault_cfi import * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, something I missed in #17170. More proper solution would be to add pixelTracks_cfi.py
, move
pixelTracks = _pixelTracksDefault.clone()
_SeedingHitSets = dict(SeedingHitSets = "pixelTracksHitQuadruplets")
trackingPhase1PU70.toModify(pixelTracks, **_SeedingHitSets)
trackingPhase2PU140.toModify(pixelTracks, **_SeedingHitSets)
from RecoPixelVertexing/PixelTrackFitting/python/PixelTracks_cff.py there, and fix all imports.
@Martin-Grunewald Depending on your preference, I can do it now, after this PR, or leave it to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@makortel
Please you do that part after this PR as I am not the expert in this... Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok.
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
+1 |
+1 for #17438 1969bd5
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
+1 |
Cleanup (following #17098) for HLT ConfDB parsing.
PR based on CMSSW_9_0_X_2017-02-06-2300.