make TrackExtra fully persistent because of FastSimPU #17367
Conversation
|
A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_9_0_X. It involves the following packages: DataFormats/TrackReco @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
@cmsbuild , please test |
|
The tests are being triggered in jenkins. |
|
so nothing we run will test this... will try to restart IBs with this change included |
|
@slava77 - please comment if you have concerns (I guess knowing the RECO size change is the one concern i can think of) |
|
On 2/1/17 11:31 AM, David Lange wrote:
@slava77 <https://github.com/slava77> - please comment if you have
concerns (I guess knowing the RECO size change is the one concern i can
think of)
just the event size
…
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#17367 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AEdcbh23mGkEv0HaJ6NiXNp34sD9gmyRks5rYF8YgaJpZM4LzrpZ>.
|
|
we can also remove the assert: after all these tracks were not accompanied by neither Trajectories nor by filled rechits, so they cannot be used to do any real reconstruction nor any analysis (DQM etc) that was relying on Trajectory or hits... |
|
On 2/1/17 11:44 AM, Vincenzo Innocente wrote:
we can also remove the assert: after all these tracks were not
accompanied by neither Trajectories nor by filled rechits, so they
cannot be used to do any real reconstruction nor any analysis (DQM etc)
that was relying on Trajectory or hits...
even better.
if garbage input can be detected/removed at the source even better
… —
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#17367 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AEdcbiBs0XGEkSehCxua5CCXrvJ77Z6Wks5rYGIfgaJpZM4LzrpZ>.
|
|
yes, definitely.
… On Feb 1, 2017, at 11:46 AM, Slava Krutelyov ***@***.***> wrote:
On 2/1/17 11:44 AM, Vincenzo Innocente wrote:
> we can also remove the assert: after all these tracks were not
> accompanied by neither Trajectories nor by filled rechits, so they
> cannot be used to do any real reconstruction nor any analysis (DQM etc)
> that was relying on Trajectory or hits...
>
even better.
if garbage input can be detected/removed at the source even better
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#17367 (comment)>, or
> mute the thread
> <https://github.com/notifications/unsubscribe-auth/AEdcbiBs0XGEkSehCxua5CCXrvJ77Z6Wks5rYGIfgaJpZM4LzrpZ>.
>
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
So, what is the decision? revert this and remove the assert and propagate "garbage" as FastSim tracks are garbage anyhow? |
|
Comparison job queued. |
|
The TrackExtras size goes up by a factor of ~1.8 in my 2016E JetHT test (136.761). |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
|
|
+1
|
Fix an issue observed after #17098 was merged
To fix FastSim wf with PU (such as 25400) a new library need to be generated