Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undo TrackExtra size increase done in #17367 #17372

Open
slava77 opened this issue Feb 1, 2017 · 12 comments
Open

undo TrackExtra size increase done in #17367 #17372

slava77 opened this issue Feb 1, 2017 · 12 comments

Comments

@slava77
Copy link
Contributor

slava77 commented Feb 1, 2017

this was done to get 900pre3 going and gives about 10% increase in RECO size.
Follow up will need to have some changes in fastsim first.

@VinInn @ssekmen

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2017

A new Issue was created by @slava77 Slava Krutelyov.

@davidlange6, @Dr15Jones, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@slava77
Copy link
Contributor Author

slava77 commented Mar 8, 2018

@VinInn @ssekmen @mdhildreth
Are we in position now to advance with this issue?

Recall that the RECO data tier was increased by 10% due to issues in FastSim with PU (#17367)

@smuzaffar
Copy link
Contributor

@slava77 , any update on this?

@slava77
Copy link
Contributor Author

slava77 commented May 28, 2020

adding TRK conveners
@mtosi @JanFSchulte

@slava77
Copy link
Contributor Author

slava77 commented May 28, 2020

assign reconstruction,simulation

@cmsbuild
Copy link
Contributor

New categories assigned: reconstruction,simulation

@mdhildreth,@slava77,@perrotta,@civanch you have been requested to review this Pull request/Issue and eventually sign? Thanks

@slava77
Copy link
Contributor Author

slava77 commented Feb 12, 2021

(to refresh the status) this is still active in a way; there was a recent discussion in connection with #30544 (which remained as an RFC and closed; a more generic variant of #31217, which was merged).

@cms-sw/fastsim-l2

the point here is to make the following data members transient (again)

   TrajParams=vector<LocalTrajectoryParameters> m_trajParams;
   Chi2sFive=vector<uchar> m_chi2sX5;  // chi2 * 5  chopped at 255

To quote a few pieces from the email thread in August 2020 (after we narrowed down that the only use case is apparently in FastTrackDeDxProducer):
@slava77 :

My somewhat simplistic understanding of the fastsim use case is that
FastTrackDeDxProducer can use propagated ~expected trajectory parameters
instead of the actual local trajectory parameters from the fit.

@VinInn :

In very good approximation yes (One can even refit the track starting from the hit (this is done for some DQM module)...):
I agree.
Not "Fast" though....

@slava77
Copy link
Contributor Author

slava77 commented Feb 12, 2021

assign fastsim

@cmsbuild
Copy link
Contributor

New categories assigned: fastsim

@mdhildreth,@sbein,@ssekmen,@lveldere,@civanch you have been requested to review this Pull request/Issue and eventually sign? Thanks

@slava77
Copy link
Contributor Author

slava77 commented Jul 22, 2021

@cms-sw/fastsim-l2
was there a follow up to this?

Please clarify.
Thank you.

@jpata
Copy link
Contributor

jpata commented May 5, 2022

@cms-sw/fastsim-l2 any update here?

@smuzaffar
Copy link
Contributor

@cms-sw/fastsim-l2 any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants