Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] Update AXOL1TL to v4.0.0 #9272

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

thesps
Copy link
Contributor

@thesps thesps commented Jun 27, 2024

Backport of #9271

@thesps thesps changed the title Update AXOL1TL to v4.0.0 for new model [14_0_X] Update AXOL1TL to v4.0.0 for new model Jun 27, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 27, 2024

A new Pull Request was created by @thesps for branch IB/CMSSW_14_0_X/master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@missirol, @mmusich this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 27, 2024

cms-bot internal usage

@thesps thesps changed the title [14_0_X] Update AXOL1TL to v4.0.0 for new model [14_0_X] Update AXOL1TL to v4.0.0 Jun 27, 2024
@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c50e9/40136/summary.html
COMMIT: 60b8474
CMSSW: CMSSW_14_0_X_2024-06-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9272/40136/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 8 lines from the logs
  • Reco comparison results: 62 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3342528
  • DQMHistoTests: Total failures: 1219
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3341289
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 9.235 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 0.048 KiB L1T/L1TriggerVsReco
  • DQMHistoSizes: changed ( 1000.0,... ): 0.037 KiB Tracking/EventInfo
  • DQMHistoSizes: changed ( 1000.0,... ): 0.036 KiB SiStrip/EventInfo
  • DQMHistoSizes: changed ( 1000.0,... ): 0.035 KiB L1TEMU/EventInfo
  • DQMHistoSizes: changed ( 1000.0,... ): 0.034 KiB Muons/EventInfo
  • DQMHistoSizes: changed ( 1000.0,... ): 0.034 KiB Pixel/EventInfo
  • DQMHistoSizes: changed ( 1000.0,... ): 0.033 KiB Ecal/EventInfo
  • DQMHistoSizes: changed ( 1000.0,... ): 0.032 KiB HLT/EventInfo
  • DQMHistoSizes: changed ( 1000.0,... ): 0.032 KiB L1T/EventInfo
  • DQMHistoSizes: changed ( 1000.0,... ): 0.032 KiB RPC/EventInfo
  • DQMHistoSizes: changed ( 1000.0 ): ...
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor

@cms-sw/externals-l2 Just a heads up, this is potentially desired by Wednesday to make HLT deadlines. Would there be any objection to signing it?

@mmusich
Copy link

mmusich commented Jul 2, 2024

urgent

@mmusich
Copy link

mmusich commented Jul 2, 2024

@smuzaffar please sign, this is in the way of the next trigger train, see cms-sw/cmssw#45356 (comment) thank you.

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2024

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link

+1

@cmsbuild cmsbuild merged commit 1055d8d into cms-sw:IB/CMSSW_14_0_X/master Jul 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants