Saving score as part of AXOL1TL Emulator

[quinnanm]

PR description:

This adds score-saving to the AXOL1TL software emulation by creating a new "AXOL1TLScore" DataFormat and saving it as an output of the GlobalProducer. It is then saved to the l1 ntuple as a float in the "l1AXOEmuTree". This is enabled by default as a switch in the GlobalProducer "saveAxoScore". This update was presented in the most recent offline sw meeting [1]. No additional dependencies or menu changes are required.

[1] https://indico.cern.ch/event/1426003/#23-axol1tl-emulator

PR validation:

The code was checked with usual cms code checks, and tested by running re-emulation on a test ntuple.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This will likely be back ported into 14_0_X

[cmsbuild]

@quinnanm, CMSSW_14_1_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45227/40600

• This PR adds an extra 56KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/L1TGlobal/interface/GlobalBoard.h modified in PR(s): CICADA-uGT emulator additions #44222
  • File L1Trigger/L1TGlobal/plugins/L1TGlobalProducer.cc modified in PR(s): CICADA-uGT emulator additions #44222
  • File L1Trigger/L1TGlobal/plugins/L1TGlobalProducer.h modified in PR(s): CICADA-uGT emulator additions #44222
  • File L1Trigger/L1TGlobal/src/GlobalBoard.cc modified in PR(s): CICADA-uGT emulator additions #44222

[cmsbuild]

A new Pull Request was created by @quinnanm for master.

It involves the following packages:

• DataFormats/L1TGlobal (l1)
• L1Trigger/L1TGlobal (l1)
• L1Trigger/L1TNtuples (l1)

@aloeliger, @epalencia, @cmsbuild can you please review it and eventually sign? Thanks.
@kreczko, @rovere, @Martin-Grunewald, @dinyar, @missirol, @eyigitba, @thomreis this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[quinnanm]

ok, I added a new commit with the following:

• as requested, I made sure the checksum was right and removed previous versions, addressing comment Saving score as part of AXOL1TL Emulator  #45227 (comment)
• I now initialize the AXOL1TLScore class in the GlobalProducer with no arguments, addressing comment Saving score as part of AXOL1TL Emulator  #45227 (comment)
  -code checks/code format

Thanks,
Melissa

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45227/40675

• This PR adds an extra 56KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/L1TGlobal/interface/GlobalBoard.h modified in PR(s): CICADA-uGT emulator additions #44222
  • File L1Trigger/L1TGlobal/plugins/L1TGlobalProducer.cc modified in PR(s): CICADA-uGT emulator additions #44222
  • File L1Trigger/L1TGlobal/plugins/L1TGlobalProducer.h modified in PR(s): CICADA-uGT emulator additions #44222
  • File L1Trigger/L1TGlobal/src/GlobalBoard.cc modified in PR(s): CICADA-uGT emulator additions #44222

[cmsbuild]

Pull request #45227 was updated. @cmsbuild, @aloeliger, @epalencia can you please check and sign again.

[epalencia]

@quinnanm , does the new model need to be added to external? If so, could you please take care of it?

[quinnanm]

@quinnanm , does the new model need to be added to external? If so, could you please take care of it?

Yes, we are working on adding it as a release and separate PR to cms-dist.

[Martin-Grunewald]

What is the status of and timeline for this PR, and its backport to 140X (together with the new model as external)?

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45227/40843

[cmsbuild]

Pull request #45227 was updated. @aloeliger, @cmsbuild, @epalencia can you please check and sign again.

[Martin-Grunewald]

please test

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-565b5b/40275/summary.html
COMMIT: d4cba30
CMSSW: CMSSW_14_1_X_2024-07-07-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45227/40275/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

There are some workflows for which there are errors in the baseline:
29634.911 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• You potentially removed 22 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 18 differences found in the comparisons
• DQMHistoTests: Total files compared: 47
• DQMHistoTests: Total histograms compared: 3246793
• DQMHistoTests: Total failures: 850
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3245923
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
• Checked 199 log files, 163 edm output root files, 47 DQM output files
• TriggerResults: no differences found

[Martin-Grunewald]

Looks good to go!

[Martin-Grunewald]

What is the status of signing this PR, and making its backport to 140X ?
@aloeliger @quinnanm

[aloeliger]

@Martin-Grunewald Distracted mostly. If HLT is good with it's status, I'll check again and sign.

[aloeliger]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1