-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BuildRules] Fix for alpaka backend dict header/xml files flags #8705
Conversation
test parameters:
|
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_13_3_X/master. @cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks. |
please test |
-1 Failed Tests: UnitTests Unit TestsI found 3 errors in the following unit tests: ---> test CondToolsLHCInfoNewPopConTest had ERRORS ---> test PrimaryVertex had ERRORS ---> test testPVPlotting had ERRORS Comparison SummarySummary:
|
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_3_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
1) Merge files src/alpaka/classes_serial{.h,_def.xml} into src/classes{.h,_def.xml} and update BuildFile.xml 2) Split class definitions into two files, undoing commit 42fd4a7. This is possible due to PR cms-sw/cmsdist/pull/8705. Switching to this version required a small change to the Python configuration. These two changes were suggested for PR cms-sw#42807.
1) Merge files src/alpaka/classes_serial{.h,_def.xml} into src/classes{.h,_def.xml} and update BuildFile.xml 2) Split class definitions into two files, undoing commit 42fd4a7. This is possible due to PR cms-sw/cmsdist/pull/8705. Switching to this version required a small change to the Python configuration. These two changes were suggested for PR cms-sw#42807.
1) Merge files src/alpaka/classes_serial{.h,_def.xml} into src/classes{.h,_def.xml} and update BuildFile.xml 2) Split class definitions into two files, undoing commit 42fd4a7. This is possible due to PR cms-sw/cmsdist/pull/8705. Switching to this version required a small change to the Python configuration. These two changes were suggested for PR cms-sw#42807.
Fixes cms-sw/cmssw#40846
LCG_DICT_HEADER
andLCG_DICT_XML
flags are now only used for default dictionary generation.classes_<backend>.h
andclasses_<backend>_def.xml
files. One can override this by addingALPAKA_<BACKEND>_LCG_DICT_HEADER
andALPAKA_<BACKEND>_LCG_DICT_XML
BuildFile flags. e.g