Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BuildRules] Fix for alpaka backend dict header/xml files flags #8705

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Sep 19, 2023

Fixes cms-sw/cmssw#40846

  • BuildFile's LCG_DICT_HEADER and LCG_DICT_XML flags are now only used for default dictionary generation.
  • For alpaka backend, scram now looks for classes_<backend>.h and classes_<backend>_def.xml files. One can override this by adding ALPAKA_<BACKEND>_LCG_DICT_HEADER and ALPAKA_<BACKEND>_LCG_DICT_XML BuildFile flags. e.g
 <flags ALPAKA_CUDA_LCG_DICT_HEADER="classes_cuda_1.h classes_cuda_2.h"/> 
 <flags ALPAKA_CUDA_LCG_DICT_XML="classes_cuda_def_1.xml classes_cuda_def_2.xml"/> 
 <flags ALPAKA_ROCM_LCG_DICT_HEADER="classes_rocm_1.h classes_rocm_2.h"/> 
 <flags ALPAKA_ROCM_LCG_DICT_XML="classes_rocm_def_1.xml classes_rocm_def_2.xml"/> 

@smuzaffar
Copy link
Contributor Author

test parameters:

  • full_cmssw = true

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_13_3_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@fwyzard
Copy link
Contributor

fwyzard commented Sep 19, 2023

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-886531/34822/summary.html
COMMIT: 4d67a0f
CMSSW: CMSSW_13_3_X_2023-09-19-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8705/34822/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 3 errors in the following unit tests:

---> test CondToolsLHCInfoNewPopConTest had ERRORS
---> test PrimaryVertex had ERRORS
---> test testPVPlotting had ERRORS

Comparison Summary

Summary:

  • You potentially removed 178 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3358044
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3358019
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

+externals
unit tests are not related to this change

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_3_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar deleted the smuzaffar-patch-1 branch September 21, 2023 15:44
fllor added a commit to fllor/cmssw that referenced this pull request Oct 1, 2023
1) Merge files src/alpaka/classes_serial{.h,_def.xml} into src/classes{.h,_def.xml} and update BuildFile.xml
2) Split class definitions into two files, undoing commit 42fd4a7. This is possible due to PR cms-sw/cmsdist/pull/8705. Switching to this version required a small change to the Python configuration.
These two changes were suggested for PR cms-sw#42807.
jsamudio pushed a commit to jsamudio/cmssw that referenced this pull request Oct 23, 2023
1) Merge files src/alpaka/classes_serial{.h,_def.xml} into src/classes{.h,_def.xml} and update BuildFile.xml
2) Split class definitions into two files, undoing commit 42fd4a7. This is possible due to PR cms-sw/cmsdist/pull/8705. Switching to this version required a small change to the Python configuration.
These two changes were suggested for PR cms-sw#42807.
jsamudio pushed a commit to jsamudio/cmssw that referenced this pull request Oct 25, 2023
1) Merge files src/alpaka/classes_serial{.h,_def.xml} into src/classes{.h,_def.xml} and update BuildFile.xml
2) Split class definitions into two files, undoing commit 42fd4a7. This is possible due to PR cms-sw/cmsdist/pull/8705. Switching to this version required a small change to the Python configuration.
These two changes were suggested for PR cms-sw#42807.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interplay of LCG_DICT_HEADER and LCG_DICT_XML with ALPAKA_BACKENDS
3 participants