Skip to content

Commit

Permalink
Merge class definitions of DataFormats/RecoParticleFlow subpackage
Browse files Browse the repository at this point in the history
The framework currently cannot handle Alpaka modules with multiple class definitions. Apparently, the separation of the class definitions was introduced more than 10 years ago for compatibility with additional CPU architectures. It is not clear to me if this separation is still necessary or if this merging has unintended side-effects.
  • Loading branch information
fllor committed Aug 17, 2023
1 parent c2e865a commit 42fd4a7
Show file tree
Hide file tree
Showing 5 changed files with 60 additions and 120 deletions.
2 changes: 0 additions & 2 deletions DataFormats/ParticleFlowReco/BuildFile.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@
<use name="FWCore/MessageLogger"/>
<use name="rootcore"/>
<use name="rootmath"/>
<flags LCG_DICT_HEADER="classes_1.h classes_2.h"/>
<flags LCG_DICT_XML="classes_def_1.xml classes_def_2.xml"/>
<export>
<lib name="1"/>
</export>
File renamed without changes.
54 changes: 0 additions & 54 deletions DataFormats/ParticleFlowReco/src/classes_1.h

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<lcgdict>
<selection>

<!-- from classes_def_2.xml -->
<class name="reco::PFCluster" ClassVersion="17">
<version ClassVersion="17" checksum="3021111509"/>
<version ClassVersion="16" checksum="1786894710"/>
Expand Down Expand Up @@ -303,8 +304,67 @@

<class name="edm::Wrapper<edm::RefVector<std::vector<reco::RecoPFClusterRefCandidate>,reco::RecoPFClusterRefCandidate,edm::refhelper::FindUsingAdvance<std::vector<reco::RecoPFClusterRefCandidate>,reco::RecoPFClusterRefCandidate> > >" />

<!-- from classes_def_1.xml -->
<class name="reco::PFNuclearInteraction" ClassVersion="10">
<version ClassVersion="10" checksum="1573561360"/>
</class>
<class name="std::vector<reco::PFNuclearInteraction>" />
<class name="edm::Wrapper<std::vector<reco::PFNuclearInteraction> >" />
<class name="edm::Ref<std::vector<reco::PFNuclearInteraction>, reco::PFNuclearInteraction, edm::refhelper::FindUsingAdvance<std::vector<reco::PFNuclearInteraction>, reco::PFNuclearInteraction> >" />
<class name="edm::RefProd<std::vector<reco::PFNuclearInteraction> >" />
<class name="edm::RefVector<std::vector<reco::PFNuclearInteraction>, reco::PFNuclearInteraction, edm::refhelper::FindUsingAdvance<std::vector<reco::PFNuclearInteraction>, reco::PFNuclearInteraction> >" />


<class name="reco::PFDisplacedTrackerVertex" ClassVersion="10">
<version ClassVersion="10" checksum="2059737151"/>
</class>
<class name="std::vector<reco::PFDisplacedTrackerVertex>" />
<class name="edm::Wrapper<std::vector<reco::PFDisplacedTrackerVertex> >" />
<class name="edm::Ref<std::vector<reco::PFDisplacedTrackerVertex>, reco::PFDisplacedTrackerVertex, edm::refhelper::FindUsingAdvance<std::vector<reco::PFDisplacedTrackerVertex>, reco::PFDisplacedTrackerVertex> >" />
<class name="edm::RefProd<std::vector<reco::PFDisplacedTrackerVertex> >" />
<class name="edm::RefVector<std::vector<reco::PFDisplacedTrackerVertex>, reco::PFDisplacedTrackerVertex, edm::refhelper::FindUsingAdvance<std::vector<reco::PFDisplacedTrackerVertex>, reco::PFDisplacedTrackerVertex> >" />

<class name="reco::PFConversion" ClassVersion="10">
<version ClassVersion="10" checksum="2417207933"/>
</class>
<class name="std::vector<reco::PFConversion>"/>
<class name="edm::Wrapper<std::vector<reco::PFConversion> >"/>
<class name="edm::Ref<std::vector<reco::PFConversion>,reco::PFConversion,edm::refhelper::FindUsingAdvance<std::vector<reco::PFConversion>,reco::PFConversion> >"/>
<class name="edm::RefProd<std::vector<reco::PFConversion> >"/>
<class name="edm::RefVector<std::vector<reco::PFConversion>,reco::PFConversion,edm::refhelper::FindUsingAdvance<std::vector<reco::PFConversion>,reco::PFConversion> >"/>
<class name="std::vector<edm::Ref<std::vector<reco::PFRecTrack>,reco::PFRecTrack,edm::refhelper::FindUsingAdvance<std::vector<reco::PFRecTrack>,reco::PFRecTrack> > >"/>

<class name="reco::PFV0" ClassVersion="10">
<version ClassVersion="10" checksum="40832700"/>
</class>
<class name="std::vector<reco::PFV0>" />
<class name="edm::Wrapper<std::vector<reco::PFV0> >" />
<class name="edm::Ref<std::vector<reco::PFV0>, reco::PFV0, edm::refhelper::FindUsingAdvance<std::vector<reco::PFV0>, reco::PFV0> >" />
<class name="edm::RefProd<std::vector<reco::PFV0> >" />
<class name="edm::RefVector<std::vector<reco::PFV0>, reco::PFV0, edm::refhelper::FindUsingAdvance<std::vector<reco::PFV0>, reco::PFV0> >" />
<class name="edm::Ref<std::vector<reco::VertexCompositeCandidate>,reco::VertexCompositeCandidate,edm::refhelper::FindUsingAdvance<std::vector<reco::VertexCompositeCandidate>,reco::VertexCompositeCandidate> >" />


<class name="reco::ConvBremSeed" ClassVersion="12">
<version ClassVersion="10" checksum="2980747190"/>
<version ClassVersion="11" checksum="637662266"/>
<version ClassVersion="12" checksum="2604169839"/>
</class>
<class name="std::vector<reco::ConvBremSeed>"/>
<class name="edm::Ref<std::vector<reco::ConvBremSeed>,reco::ConvBremSeed,edm::refhelper::FindUsingAdvance<std::vector<reco::ConvBremSeed>,reco::ConvBremSeed> >"/>
<class name="edm::RefProd<std::vector<reco::ConvBremSeed> >"/>
<class name="edm::Wrapper<std::vector<reco::ConvBremSeed> >"/>
<class name="edm::RefVector<std::vector<reco::ConvBremSeed>,reco::ConvBremSeed,edm::refhelper::FindUsingAdvance<std::vector<reco::ConvBremSeed>,reco::ConvBremSeed> >"/>
<class name="edm::Wrapper<edm::RefVector<std::vector<reco::ConvBremSeed>,reco::ConvBremSeed,edm::refhelper::FindUsingAdvance<std::vector<reco::ConvBremSeed>,reco::ConvBremSeed> > >"/>
<class name="edm::RefToBase<reco::ConvBremSeed>"/>
<class name="edm::reftobase::BaseHolder<reco::ConvBremSeed>" />
<class name="edm::reftobase::RefHolder<edm::Ref<std::vector<reco::ConvBremSeed>,reco::ConvBremSeed,edm::refhelper::FindUsingAdvance<std::vector<reco::ConvBremSeed>,reco::ConvBremSeed> > >"/>
<class name="edm::reftobase::Holder<reco::ConvBremSeed,edm::Ref<std::vector<reco::ConvBremSeed>,reco::ConvBremSeed,edm::refhelper::FindUsingAdvance<std::vector<reco::ConvBremSeed>,reco::ConvBremSeed> > >"/>

</selection>

<exclusion>
<!-- from classes_def_2.xml -->
<class name="edm::OwnVector<reco::PFBlockElement, edm::ClonePolicy<reco::PFBlockElement> >">
<method name="sort"/>
</class>
Expand Down
64 changes: 0 additions & 64 deletions DataFormats/ParticleFlowReco/src/classes_def_1.xml

This file was deleted.

0 comments on commit 42fd4a7

Please sign in to comment.