Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tag for DQM-EcalMonitorClient to V00-03-00 [13_0_X] #8477

Conversation

perrotta
Copy link
Contributor

Move DQM-EcalMonitorClient data to new tag, see
cms-data/DQM-EcalMonitorClient#3

Backport #8476 to 13_0_X

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @perrotta (Andrea Perrotta) for branch IB/CMSSW_13_0_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@perrotta
Copy link
Contributor Author

please test

@perrotta
Copy link
Contributor Author

@abhih1 this was forgotten when cms-sw/cmssw#41195 was merged.
Now I wonder: why there are no crashes in the IB after the merge of cms-sw/cmssw#41195 , e.g. CMSSW_13_0_X_2023-04-27-2300 and CMSSW_13_0_X_2023-04-28-1100?

@abhih1
Copy link

abhih1 commented Apr 28, 2023

@abhih1 this was forgotten when cms-sw/cmssw#41195 was merged. Now I wonder: why there are no crashes in the IB after the merge of cms-sw/cmssw#41195 , e.g. CMSSW_13_0_X_2023-04-27-2300 and CMSSW_13_0_X_2023-04-28-1100?

@perrotta I'm not sure. I dont know exactly how the IB testing works, but the lines in MLClient.cc which uses those data files are only run if a Pileup condition is satisfied. So if a non-collision run was used in testing it wont be affected.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-405c5a/32221/summary.html
COMMIT: f72b2e2
CMSSW: CMSSW_13_0_X_2023-04-28-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8477/32221/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 17 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3554572
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3554547
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor Author

@perrotta
Copy link
Contributor Author

merge

@cmsbuild cmsbuild merged commit 035324d into IB/CMSSW_13_0_X/master Apr 28, 2023
@smuzaffar smuzaffar deleted the update-DQM-EcalMonitorClient-to-V00-03-00_13_0_X branch May 8, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants