Imported yaml-cpp 0.7.0 #8410

forthommel · 2023-03-28T13:27:43Z

This PR imports version 0.7.0 of the commonly used yaml-cpp into the CMS environment.

cmsbuild · 2023-03-28T13:28:06Z

A new Pull Request was created by @forthommel (Laurent Forthomme) for branch IB/CMSSW_13_1_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

smuzaffar · 2023-03-28T13:35:48Z

please test

cmsbuild · 2023-03-28T14:00:19Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-701bcc/31644/summary.html
COMMIT: a609567
CMSSW: CMSSW_13_1_X_2023-03-28-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8410/31644/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

-rw-rw-r-- root/root       299 2021-07-10 17:53 yaml-cpp-yaml-cpp-0.7.0/yaml-cpp.pc.in
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd yaml-cpp-0.7.0
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.RwAcFy: line 40: cd: yaml-cpp-0.7.0: No such file or directory
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.RwAcFy (%prep)


RPM build errors:
line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: external+yaml-cpp+0.7.0-ec61c88d010feb3bfde87bd2a5f9083d
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.RwAcFy (%prep)

yaml-cpp.spec

cmsbuild · 2023-03-28T14:09:22Z

Pull request #8410 was updated.

smuzaffar · 2023-03-28T14:30:29Z

please test

smuzaffar · 2023-03-28T15:08:09Z

please test for el8_ppc64le_gcc11

smuzaffar · 2023-03-28T15:08:36Z

please test for el8_aarch64_gcc11

smuzaffar · 2023-03-28T15:08:52Z

please test for el9_amd64_gcc11

smuzaffar · 2023-03-28T15:09:09Z

please test for slc7_amd64_gcc11

yaml-cpp.spec

cmsbuild · 2023-03-28T16:26:32Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-701bcc/31652/summary.html
COMMIT: e210a93
CMSSW: CMSSW_13_1_X_2023-03-27-2300/el8_aarch64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8410/31652/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@cms-sw Update tag for CondTools-Hcal to V00-01-00 #8409

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-701bcc/31652/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-701bcc/31652/git-merge-result

cmsbuild · 2023-03-28T17:29:14Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-701bcc/31649/summary.html
COMMIT: e210a93
CMSSW: CMSSW_13_1_X_2023-03-28-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8410/31649/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
24234.61 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

You potentially removed 8 lines from the logs
Reco comparison results: 12 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3554236
DQMHistoTests: Total failures: 10
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3554204
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 213 log files, 164 edm output root files, 49 DQM output files
TriggerResults: no differences found

cmsbuild · 2023-03-28T18:48:14Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-701bcc/31657/summary.html
COMMIT: e210a93
CMSSW: CMSSW_13_1_X_2023-03-27-2300/el8_ppc64le_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8410/31657/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@cms-sw Update tag for CondTools-Hcal to V00-01-00 #8409

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-701bcc/31657/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-701bcc/31657/git-merge-result

smuzaffar · 2023-03-28T20:59:35Z

+externals
looks good

cmsbuild · 2023-03-28T20:59:57Z

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2023-03-29T00:32:39Z

+1

Comparison Summary

Summary:

You potentially added 86 lines to the logs
Reco comparison results: 62927 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3554236
DQMHistoTests: Total failures: 143871
DQMHistoTests: Total nulls: 249
DQMHistoTests: Total successes: 3410094
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.706 KiB( 48 files compared)
DQMHistoSizes: changed ( 10224.0 ): 0.063 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 11834.0 ): 2.904 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 250202.181 ): -1.061 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): -0.479 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 7.3 ): -2.133 KiB SiStrip/MechanicalView
Checked 213 log files, 164 edm output root files, 49 DQM output files

cmsbuild · 2023-03-29T01:30:07Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-701bcc/31651/summary.html
COMMIT: e210a93
CMSSW: CMSSW_13_1_X_2023-03-28-1100/slc7_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8410/31651/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@cms-sw Update tag for CondTools-Hcal to V00-01-00 #8409

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-701bcc/31651/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-701bcc/31651/git-merge-result

Comparison Summary

There are some workflows for which there are errors in the baseline:
24234.61 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

You potentially added 94 lines to the logs
Reco comparison results: 68541 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3554236
DQMHistoTests: Total failures: 173792
DQMHistoTests: Total nulls: 283
DQMHistoTests: Total successes: 3380139
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -3.507 KiB( 48 files compared)
DQMHistoSizes: changed ( 10224.0 ): -0.607 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 11834.0 ): 1.668 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 250202.181 ): -1.236 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): -0.787 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 7.3 ): -2.545 KiB SiStrip/MechanicalView
Checked 213 log files, 164 edm output root files, 49 DQM output files
TriggerResults: found differences in 18 / 47 workflows

forthommel · 2023-03-29T14:04:20Z

Many thanks for the extremely fast interaction (and follow-up PR), @smuzaffar !

Imported yaml-cpp 0.7.0

a609567

cmsbuild added tests-pending externals-pending pending-signatures orp-pending labels Mar 28, 2023

forthommel mentioned this pull request Mar 28, 2023

Revert "Update yaml-cpp to 0.7.0" #7787

Merged

cmsbuild added tests-started and removed tests-pending labels Mar 28, 2023

cmsbuild added tests-rejected and removed tests-started labels Mar 28, 2023

smuzaffar reviewed Mar 28, 2023

View reviewed changes

yaml-cpp.spec Outdated Show resolved Hide resolved

Updated path to archive

e210a93

cmsbuild added tests-pending and removed tests-rejected labels Mar 28, 2023

cmsbuild added tests-started and removed tests-pending labels Mar 28, 2023

smuzaffar approved these changes Mar 28, 2023

View reviewed changes

yaml-cpp.spec Outdated Show resolved Hide resolved

cmsbuild added tests-approved and removed tests-started labels Mar 28, 2023

smuzaffar merged commit f870055 into cms-sw:IB/CMSSW_13_1_X/master Mar 28, 2023

cmsbuild added externals-approved fully-signed and removed externals-pending pending-signatures labels Mar 28, 2023

cmsbuild mentioned this pull request Mar 29, 2023

yaml-cpp: fix relocation #8411

Merged

forthommel deleted the yaml-cpp branch March 29, 2023 14:04

cmsbuild mentioned this pull request Mar 29, 2023

Use VecGeom for limited number of shapes #8408

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Imported yaml-cpp 0.7.0 #8410

Imported yaml-cpp 0.7.0 #8410

forthommel commented Mar 28, 2023

cmsbuild commented Mar 28, 2023

smuzaffar commented Mar 28, 2023

cmsbuild commented Mar 28, 2023

cmsbuild commented Mar 28, 2023

smuzaffar commented Mar 28, 2023

smuzaffar commented Mar 28, 2023

smuzaffar commented Mar 28, 2023

smuzaffar commented Mar 28, 2023

smuzaffar commented Mar 28, 2023

cmsbuild commented Mar 28, 2023

cmsbuild commented Mar 28, 2023

cmsbuild commented Mar 28, 2023

smuzaffar commented Mar 28, 2023

cmsbuild commented Mar 28, 2023

cmsbuild commented Mar 29, 2023

cmsbuild commented Mar 29, 2023

forthommel commented Mar 29, 2023

Imported yaml-cpp 0.7.0 #8410

Imported yaml-cpp 0.7.0 #8410

Conversation

forthommel commented Mar 28, 2023

cmsbuild commented Mar 28, 2023

smuzaffar commented Mar 28, 2023

cmsbuild commented Mar 28, 2023

External Build

cmsbuild commented Mar 28, 2023

smuzaffar commented Mar 28, 2023

smuzaffar commented Mar 28, 2023

smuzaffar commented Mar 28, 2023

smuzaffar commented Mar 28, 2023

smuzaffar commented Mar 28, 2023

cmsbuild commented Mar 28, 2023

cmsbuild commented Mar 28, 2023

Comparison Summary

cmsbuild commented Mar 28, 2023

smuzaffar commented Mar 28, 2023

cmsbuild commented Mar 28, 2023

cmsbuild commented Mar 29, 2023

Comparison Summary

cmsbuild commented Mar 29, 2023

Comparison Summary

forthommel commented Mar 29, 2023