Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use VecGeom for limited number of shapes #8408

Merged

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Mar 28, 2023

It is recommended to use VecGeom for 3 shapes CONS, POLYCONS, and POLYHEDRA. Expected CPU performance improvement and improved robustness.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for branch IB/CMSSW_13_1_X/g4_vecgeom.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-927f8e/31641/summary.html
COMMIT: 05106ed
CMSSW: CMSSW_13_1_G4VECGEOM_X_2023-03-26-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8408/31641/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 15 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 66112 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3554236
  • DQMHistoTests: Total failures: 158402
  • DQMHistoTests: Total nulls: 286
  • DQMHistoTests: Total successes: 3395526
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -10.774000000000001 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.182 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 11634.0,... ): -0.360 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 11834.0 ): -1.641 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13234.0,... ): -0.234 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 250202.181 ): -1.055 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.129 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): -6.938 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 8.0 ): 1.537 KiB SiStrip/MechanicalView
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 19 / 47 workflows

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

Pull request #8408 was updated.

@smuzaffar
Copy link
Contributor

+externals
ah this is for g4/vecgeom IB. I was worried to see too many comparison differences .

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_1_X/g4_vecgeom IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar merged commit 151e880 into cms-sw:IB/CMSSW_13_1_X/g4_vecgeom Mar 29, 2023
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-927f8e/31669/summary.html
COMMIT: 1594df1
CMSSW: CMSSW_13_1_G4VECGEOM_X_2023-03-26-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8408/31669/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-927f8e/31669/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-927f8e/31669/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 15 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 66099 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3554236
  • DQMHistoTests: Total failures: 158512
  • DQMHistoTests: Total nulls: 426
  • DQMHistoTests: Total successes: 3395276
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -4.493999999999999 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.182 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 11634.0,... ): 0.691 KiB L1T/L1TStage2uGMT
  • DQMHistoSizes: changed ( 11634.0,... ): -0.360 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 11634.0,... ): 0.117 KiB L1TEMU/L1TdeStage2uGMT
  • DQMHistoSizes: changed ( 11834.0 ): -1.641 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13234.0,... ): -0.234 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 250202.181 ): -1.055 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.129 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 312.0 ): -1.805 KiB L1T/L1TStage2uGT
  • DQMHistoSizes: changed ( 7.3 ): -6.938 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 8.0 ): ...
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 19 / 47 workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants