Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ROCM_FLAGS [12.5.x] #8048

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Aug 29, 2022

Delay the expansion of the COMPILER environment variables.

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 29, 2022

type bugfix

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 29, 2022

backport #8046

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 29, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 29, 2022

A new Pull Request was created by @fwyzard (Andrea Bocci) for branch IB/CMSSW_12_5_X/master.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

+externals
@cms-sw/orp-l2 , this is just a technical bug fix for rocm toolfile. Feel free to include it for 12.5.X

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_5_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5950ab/27154/summary.html
COMMIT: b371d1d
CMSSW: CMSSW_12_5_X_2022-08-28-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8048/27154/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3695708
  • DQMHistoTests: Total failures: 18
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3695668
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

@perrotta @rappoccio this is bug fix and safe to merge it for 12.5.X

@perrotta
Copy link
Contributor

perrotta commented Sep 1, 2022

+1

@cmsbuild cmsbuild merged commit ab547c9 into cms-sw:IB/CMSSW_12_5_X/master Sep 1, 2022
@fwyzard fwyzard deleted the IB/CMSSW_12_5_X/master_rocm_use_host_triple branch December 19, 2022 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants