Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ROCM_FLAGS #8046

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Aug 27, 2022

Delay the expansion of the COMPILER environment variables.

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 27, 2022

assign heterogeneous

@cmsbuild
Copy link
Contributor

New categories assigned: heterogeneous

@fwyzard,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for branch IB/CMSSW_12_5_X/master.

@smuzaffar, @makortel, @aandvalenzuela, @iarspider, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 27, 2022

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0459a/27143/summary.html
COMMIT: b371d1d
CMSSW: CMSSW_12_5_X_2022-08-27-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8046/27143/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3695708
  • DQMHistoTests: Total failures: 16
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3695670
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 27, 2022

I'm not sure if this is the intended behaviour... I'll check on Monday

@smuzaffar smuzaffar changed the base branch from IB/CMSSW_12_5_X/master to IB/CMSSW_12_6_X/master August 28, 2022 09:06
@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 28, 2022

OK, from what I can understand it looks good...

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 28, 2022

+heterogeneous

@smuzaffar
Copy link
Contributor

+externals

@smuzaffar smuzaffar merged commit 1738bce into cms-sw:IB/CMSSW_12_6_X/master Aug 29, 2022
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_6_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants