Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DD4Hep to latest on master #6594

Conversation

mrodozov
Copy link
Contributor

Previous pr was merged to make an IB for debugging a unit test
Deps on tbb removed (not used)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_11_3_X/master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@mrodozov
Copy link
Contributor Author

@cvuosalo I started an IB CMSSW_11_3_X_2021-01-26-0100 that includes the changes from this PR
once it's ready you'll need to get it with scram
scram p CMSSW_11_3_X_2021-01-26-0100
and run the unit test and the relval failing

@mrodozov
Copy link
Contributor Author

@cvuosalo @ianna
using the CMSSW_11_3_X_2021-01-26-0100 IB will get the conditions in which the
GeometryDTGeometryBuilderTestDriver
test is failing - it fails the same way as in the PR, and it includes the dd4hep from this PR

If you want to build the external and have it locally installed, so you can also patch it you can do:

git clone https://github.com/cms-sw/cms-bot
./cms-bot/test-prs.sh -a slc7_amd64_gcc900 cms-sw/cmsdist#6594 -r CMSSW_11_3_X_2021-01-26-1100

This takes few hours to build the external and all related to it changes in CMSSW

@cvuosalo
Copy link

@mrodozov @ianna With the special IB, I ran DD4hep tests. Once again, the DDDefintion error is appearing. I thought it had been fixed. Any ideas about it?

DD4hep           WARN  ++ Using globally Geant4 unit system (mm,ns,MeV)
PluginService    ERROR Factory requested: DDDefinition_XML_reader (N10__cxxabiv120__function_type_infoE) :bad any_cast
PluginService    ERROR Stub is invalid!
dd4hep: Failed to locate plugin to interprete files of type "DDDefinition" - no factory:DDDefinition_XML_reader. 		No factory with name Create(DDDefinition_XML_reader) for type DDDefinition_XML_reader found.
		Please check library load path and/or plugin factory name.
dd4hep: while parsing /cvmfs/cms-ib.cern.ch/nweek-02665/slc7_amd64_gcc900/cms/cmssw/CMSSW_11_3_X_2021-01-26-0100/src/Geometry/CMSCommonData/data/dd4hep/cmsExtendedGeometry2021.xml
dd4hep: with plugin:DD4hep_CompactLoader

@mrodozov
Copy link
Contributor Author

please test

@mrodozov
Copy link
Contributor Author

@cvuosalo I'm runing the tests to have the logs and search for the missing symbols mentioned yesterday.

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-00b6c7/12575/summary.html
COMMIT: 1eb6c11
CMSSW: CMSSW_11_3_X_2021-01-27-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/6594/12575/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test GeometryDTGeometryBuilderTestDriver had ERRORS

RelVals

  • 11624.91111624.911_TTbar_13+2021_DD4hep+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+Reco+HARVEST+ALCA/step1_TTbar_13+2021_DD4hep+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+Reco+HARVEST+ALCA.log

@mrodozov
Copy link
Contributor Author

@cvuosalo there is something mentioned here:
cms-sw/cmssw#32181 (comment)

@cvuosalo
Copy link

@mrodozov Markus Frank suggests that the problem with DDDefinition may be caused by:

  1. ROOT map file not being properly generated.
  2. Load-library path is wrong.

Are either of these possible?

@cvuosalo
Copy link

The DDDefinition error can be reproduced by running "cmsRun Geometry/EcalCommonData/test/python/dumpECDD4Hep_cfg.py" in the special IB.

@mrodozov
Copy link
Contributor Author

I'll see it later when I'm finished with other things to be done would you elaborate which Library-path (to cmssw generated lib, dd4hep lib path etc) and which ROOT map.
You can also type
env
to see all the environment vars which are holding the library paths

@cvuosalo
Copy link

@mrodozov I was just repeating suggestons from Markus. I don't have more to add about them.
I have noticed the DDDefinition error is also appearing in CMSSW_11_3_ASAN_X_2021-01-27-2300. I'm not sure what that tells us.

@smuzaffar
Copy link
Contributor

closing in favor of #6612 6612

@smuzaffar smuzaffar closed this Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants