Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tag for L1Trigger-L1TCalorimeter to V01-01-00 #6004

Merged

Conversation

cmsbuild
Copy link
Contributor

Move L1Trigger-L1TCalorimeter data to new tag, see
cms-data/L1Trigger-L1TCalorimeter#22

@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for branch IB/CMSSW_11_2_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

+externals
this has been tested via data externals and only contains new files, so can be mrged safely

@smuzaffar smuzaffar merged commit 4fedc94 into IB/CMSSW_11_2_X/master Jun 29, 2020
@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 29, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor Author

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_2_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

Thanks, do you have an automatic way to make the cms-dist PR for the backport as well?
In this case the backport is just one single line, but it is good to know.

@mrodozov mrodozov deleted the update-L1Trigger-L1TCalorimeter-to-V01-01-00 branch June 29, 2020 15:47
@smuzaffar
Copy link
Contributor

@silviodonato , there is a jenkins job https://cmssdt.cern.ch/jenkins/job/backport-pull-request/ whcih normaly we use for back ports for data package backports this mostly fails due to conflicits.

Which release cycle we need to backport this PR?

@cmsbuild
Copy link
Contributor Author

+1
Tested at: f715682
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d97dfa/7489/summary.html
CMSSW: CMSSW_11_2_X_2020-06-29-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor Author

Comparison job queued.

@silviodonato
Copy link
Contributor

@silviodonato , there is a jenkins job https://cmssdt.cern.ch/jenkins/job/backport-pull-request/ whcih normaly we use for back ports for data package backports this mostly fails due to conflicits.

Which release cycle we need to backport this PR?

We need a backport to 11_1_X, thanks.
cc: @rekovic

@cmsbuild
Copy link
Contributor Author

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d97dfa/7489/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2778915
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2778864
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@cmsbuild
Copy link
Contributor Author

backport failed
Reason:

Error: Failed to cherry-pick commits. Please backport this PR yourself.

mark the corrected paths with 'git add <paths>' or 'git rm <paths>'
and commit the result with: 

        git commit -c f71568232b5e45cd2bb8c0f53d6bcbcc438384ec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants