Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement special handling for draft PRs (and add tests) #2395

Merged
merged 6 commits into from
Dec 16, 2024
Merged

Implement special handling for draft PRs (and add tests) #2395

merged 6 commits into from
Dec 16, 2024

Conversation

iarspider
Copy link
Contributor

@iarspider iarspider commented Dec 6, 2024 •
edited
Loading

As discussed in cms-sw/cmssw#46747 .

  • TODO: post "PR Updated" comment even if welcome message is not found (e.g. check for bot cache).
  • TODO 2: check that welcome message is posted when PR is ready for review.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2024

A new Pull Request was created by @iarspider for branch master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2024 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

Pull request #2395 was updated.

@cmsbuild
Copy link
Contributor

Pull request #2395 was updated.

1 similar comment
@cmsbuild
Copy link
Contributor

Pull request #2395 was updated.

@smuzaffar smuzaffar force-pushed the master branch 3 times, most recently from 03f42b1 to cf14ee3 Compare December 10, 2024 18:39
@cmsbuild
Copy link
Contributor

Pull request #2395 was updated.

2 similar comments
@cmsbuild
Copy link
Contributor

Pull request #2395 was updated.

@cmsbuild
Copy link
Contributor

Pull request #2395 was updated.

@iarspider iarspider marked this pull request as ready for review December 11, 2024 11:07
@cmsbuild
Copy link
Contributor

Pull request #2395 was updated.

@iarspider iarspider requested a review from smuzaffar December 11, 2024 12:11
@cmsbuild
Copy link
Contributor

Pull request #2395 was updated.

@cmsbuild
Copy link
Contributor

Pull request #2395 was updated.

@cmsbuild
Copy link
Contributor

Pull request #2395 was updated.

1 similar comment
@cmsbuild
Copy link
Contributor

Pull request #2395 was updated.

@cmsbuild
Copy link
Contributor

Pull request #2395 was updated.

@cmsbuild
Copy link
Contributor

Pull request #2395 was updated.

@smuzaffar
Copy link
Contributor

+externals

test done via cms-sw/cmssw#46933 and cms-sw/cmssw#46965 looks good.

@smuzaffar smuzaffar merged commit 7d09b46 into master Dec 16, 2024
8 of 9 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar mentioned this pull request Dec 16, 2024
Open
@iarspider iarspider deleted the draft-prs branch December 17, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smuzaffar smuzaffar smuzaffar approved these changes

Assignees
No one assigned
Labels
externals-approved fully-signed orp-pending tests-pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iarspider @cmsbuild @smuzaffar