Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Proposal to change handing of draft PRs by bot #46747

Open
iarspider opened this issue Nov 20, 2024 · 13 comments
Open

[RFC] Proposal to change handing of draft PRs by bot #46747

iarspider opened this issue Nov 20, 2024 · 13 comments

Comments

@iarspider
Copy link
Contributor

As discussed during yesterday's Core Software meeting, we propose to change how draft PRs are handled by cms bot:

  • When a PR is in draft state, bot will not mention (@username) anyone in any of it's messages, except "New category assigned" ones
  • It will also delay posting the "greeting" message ("A new Pull Request was created...") until the PR is marked as "Ready for review" for the first time

The commands (assign, unassign, test, etc) will still work as usual, and if necessary users can ping the corresponding experts themselves.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 20, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

A new Issue was created by @iarspider.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

sounds good @iarspider
By the way, what about the PR updated message (#46650 (comment) ) . Are those be delayed too or should bot ping the explicitly assigned groups ?

@smuzaffar
Copy link
Contributor

type doc

@iarspider
Copy link
Contributor Author

iarspider commented Nov 20, 2024

By the way, what about the PR updated message (#46650 (comment) ) . Are those be delayed too or should bot ping the explicitly assigned groups ?

I think we can either skip them, or post a reduced version ("Pull request ... was updated", end of message) just to acknowledge that bot processed the new commit. All the assigned experts will get notified anyway in "greeting" message once it's posted.

@smuzaffar
Copy link
Contributor

reduced version of the message sounds reasonable

@makortel
Copy link
Contributor

Plan sounds good to me. Should we ping others (e.g. @cms-sw/all-l2) yet?

@makortel
Copy link
Contributor

assign core, orp

@cmsbuild
Copy link
Contributor

New categories assigned: core,orp

@antoniovilela,@Dr15Jones,@makortel,@mandrenguyen,@rappoccio,@sextonkennedy,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks

@iarspider
Copy link
Contributor Author

@cms-sw/all-l2 any objections? Suggestions?

@fwyzard
Copy link
Contributor

fwyzard commented Dec 3, 2024

OK for me, I guess.

@smorovic
Copy link
Contributor

smorovic commented Dec 3, 2024

No objections.

@smuzaffar
Copy link
Contributor

this has been implemented and deployed via cms-sw/cms-bot#2395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants