use uint32 to index hits [do not merge] #474
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinInn
changed the title
Validation summaryReference release CMSSW_11_1_0_pre8 at 442ae07 Validation plots/RelValTTbar_14TeV/CMSSW_11_0_0_patch1-PU_110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW
/RelValZMM_14/CMSSW_11_0_0_patch1-110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW
/RelValZEE_14/CMSSW_11_0_0_patch1-110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW
Throughput plots/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53
logs and
|
|
ok, later on I think I will have to increase the buffers as well. |
fwyzard
force-pushed
the
master
branch
5 times, most recently
from
b97d98f to
3f09c90
Compare
|
can we test this again with latest greatest? |
|
can the history of this PR be clean-up please? |
|
I think the relevant parts of this PR are equivalent to #545 |
|
I've attempted to clean up the history and rebase the original changes on top of the current @VinInn could you check if that's doing the right things, and in case force-push it here ? |
|
It still look a big mess. |
|
This diff: master...cms-patatrack:VinInn_Hit32 |
|
thanks Marco.
pushed the button and done as #583
v.
… On 25 Nov, 2020, at 11:22 AM, Marco Musich ***@***.***> wrote:
This diff: master...cms-patatrack:VinInn_Hit32
looks simple enough... perhaps a new PR using just these commits can be created?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.
--
Il est bon de suivre sa pente, pourvu que ce soit en montant.
A.G.
http://www.flickr.com/photos/vin60/1320965757/
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to allow more than 64K hits we need to use a full-size int.
the size of the buffer is unchanged
The commit includes also code to count "forlorn doublets" (those that do to share any hits with tracks).
this code does not run by default