Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tk met #10

Closed
arizzi opened this issue Sep 21, 2017 · 5 comments
Closed

tk met #10

arizzi opened this issue Sep 21, 2017 · 5 comments

Comments

@arizzi
Copy link

arizzi commented Sep 21, 2017

No description provided.

@arizzi arizzi mentioned this issue Sep 25, 2017
Merged
@arizzi
Copy link
Author

arizzi commented Sep 25, 2017

#13 implements it

@arizzi arizzi closed this as completed Sep 25, 2017
@gpetruc
Copy link

gpetruc commented Oct 3, 2017

I'll merge #13 (so that we have something for tests), and re-open the issue so that we remember to follow up once cms-sw#20655 will be merged and available in a release

@gpetruc gpetruc reopened this Oct 3, 2017
@gpetruc gpetruc added this to the on top of 940 pre3? milestone Oct 3, 2017
@arizzi
Copy link
Author

arizzi commented Oct 25, 2017

in order to properly implement this using 20655 we need

  • at least pre3 relvals (and update cmsDriver)
  • switches to use legacy method when running on 80X and 92X

@gpetruc gpetruc removed this from the on top of 940 pre3? milestone Mar 22, 2018
@fgolf
Copy link

fgolf commented Nov 9, 2018

There is a discrepancy in the configuration used to calculate trkMET between miniAOD and nanoAOD. MiniAOD configuration selects PF candidates for trkMET calculation with selection pvAssociationQuality()>=4 (https://github.com/cms-sw/cmssw/blob/896137df27dbe57b80d2dc8a83550cac2ba9de50/PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py#L213). NanoAOD configuration instead selects with pvAssociationQuality()>=5 (https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/NanoAOD/python/met_cff.py#L8).
@arizzi

peruzzim pushed a commit that referenced this issue Dec 11, 2018
@andrzejnovak
Merge pull request #10 from andrzejnovak/switch
5f8c3a4 
Run TF only when features are filled
peruzzim pushed a commit that referenced this issue Jan 7, 2020
Merge pull request #10 from PFCal-dev/pre11_realisticstartup
f9f0e85 
Pre11 realisticstartup
@mariadalfonso
Copy link

The tkMET is being uniformized between mini and nano for the Run3 see
cms-sw#34860

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@fgolf @peruzzim @gpetruc @arizzi @mariadalfonso