Adding chsMET and trackMET to miniAOD

[zdemirag]

Adding the chsMET and chs/trkMET to miniAOD as a function of the pat MET. The chs MET will be used by the JERC group and the track MET was a request from the analyzers / nanoAOD developers.

[cmsbuild]

@zdemirag, CMSSW_9_4_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20655/965

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20655/965/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20655/965/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

[slava77]

@zdemirag
passing code-checks is required
please apply the updates.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20655/974

[cmsbuild]

A new Pull Request was created by @zdemirag (Zeynep Demiragli) for master.

It involves the following packages:

DataFormats/PatCandidates
PhysicsTools/PatAlgos

@perrotta, @cmsbuild, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @jdolen, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @rovere, @jdamgov, @JyothsnaKomaragiri, @nhanvtran, @gpetruc, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @seemasharmafnal, @cbernet this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23244/console Started: 2017/09/27 09:13

[arizzi]

can you measure the size increase on the usual 9K ttbar w/ PU relval ?

[cmsbuild]

-1

Tested at: 7fb017a

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
8c0f84b
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20655/23781/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20655/23781/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20655/23781/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

The relvals timed out after 2 hours.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
8c0f84b
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20655/23781/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20655/23781/git-merge-result

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23791/console Started: 2017/10/16 19:51

[cmsbuild]

+1
Tested at: 7fb017a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20655/23791/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
8c0f84b
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20655/23791/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20655/23791/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20655/23791/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2767139
• DQMHistoTests: Total failures: 101
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2766867
• DQMHistoTests: Total skipped: 171
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 10 edm output root files, 26 DQM output files

[perrotta]

+1

• Already signe in Adding chsMET and trackMET to miniAOD #20655 (comment)
• Later updates were just cosmetics

[davidlange6]

merge