Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Menu Table into the new menu tools structure #68

Merged
merged 27 commits into from
Apr 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
d2ae965
roughtly move new rate tools to new structure
danielhundhausen Feb 9, 2024
33cc075
remove old tool, run black
danielhundhausen Feb 9, 2024
506930f
fix imports in new structure
danielhundhausen Feb 9, 2024
394ba86
clean up!
danielhundhausen Feb 26, 2024
d5eac03
more cleanup!
danielhundhausen Feb 26, 2024
82f6ee1
continue refactoring of rate table
danielhundhausen Feb 27, 2024
f7794b0
fix typing; bugs
danielhundhausen Feb 27, 2024
f1f9b89
fix bug in regex substitution; variable referenced before assignment
danielhundhausen Feb 27, 2024
31f2fbb
add local index to return value from scaling application
danielhundhausen Feb 28, 2024
8353b75
fix logic of array operations
danielhundhausen Feb 28, 2024
5680aba
add PV as an object for menu table
danielhundhausen Feb 28, 2024
fde009e
set mass filed of array to 0 in scaling application
danielhundhausen Mar 1, 2024
ff42e0c
add debug output
danielhundhausen Mar 1, 2024
5507cd1
fix bug where None values were removed from array; implement printing…
danielhundhausen Mar 19, 2024
d167c29
remove configurability of output dir from rate table config
danielhundhausen Mar 19, 2024
7e76b1d
cosmetic; remove debug output
danielhundhausen Mar 19, 2024
6448bd4
fix bug in ANDing of cross masks
danielhundhausen Mar 19, 2024
4a71396
minor fixes; printout of table after each seed
danielhundhausen Mar 19, 2024
9e4acbe
fix issues
danielhundhausen Mar 20, 2024
7de290d
Merge branch 'cms-l1-dpg:main' into port_menu_table
danielhundhausen Mar 23, 2024
8ca75f4
code quality
danielhundhausen Mar 23, 2024
f013ba3
Fix Sums in rate table
danielhundhausen Mar 27, 2024
4032f45
cleanup - remove dead code and stale todos
danielhundhausen Mar 27, 2024
10395b7
update docs, make sample in rate table configurable
danielhundhausen Mar 27, 2024
69e31b1
update docs
danielhundhausen Mar 27, 2024
11e94a3
fix loading of sample config
danielhundhausen Mar 27, 2024
bd63240
add online eta cut to seeded cone puppi jet object
danielhundhausen Mar 27, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
**/__pycache__/*
*.pyc
pyenv/*
*.swp
**/*.png
**/*.pdf
**/.DS_Store
Expand Down
15 changes: 5 additions & 10 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,10 @@

## Trigger efficiencies and rates

This repository contains the python-based framework for the measurement of matching efficiencies, trigger turn-on curves, and scalings for the assessment of the physics performance of the CMS Phase-2 L1 Menu.
This repository contains the python-based framework for the measurement of matching efficiencies,
trigger turn-on curves, and scalings for the assessment of the physics performance of the CMS Phase-2 L1 Menu.

The repository is organized as follows:

* `objectPerformance`: tools for the measurement of the performance (matching efficiency, L1 turn-on efficiency curves, and online-to-offline scalings) of L1 objects. The definition of the L1 objects should follow the recommendations detailed [here](https://twiki.cern.ch/twiki/bin/view/CMS/PhaseIIL1TriggerMenuTools).

* `rates`: tools for the measurement of trigger rates starting from the scalings derived with the tools in `objectPerformance`.

Detailed instructions on how to run each step of the workflow are
provided in each folder.
For further instructions on how to run the tools, see the `docs`.

## Setup

Expand All @@ -30,7 +24,8 @@
You can then execute the tools via

```python
cach_objects <path_to_config>
cache_objects <path_to_config>
object_performance <path_to_config>
rate_plots <path_to_config>
rate_table <path_to_config>
```
1 change: 1 addition & 0 deletions configs/V29/objects/jets.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ seededConePuppiJet:
default:
cuts:
inclusive:
- "{et}>25"
- "abs({eta}) < 7"

trackerJet:
Expand Down
4 changes: 4 additions & 0 deletions configs/V29/objects/pv.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
z0L1TkPV:
label: "Primary Vertex"
ids:
default: {}
6 changes: 6 additions & 0 deletions configs/V29/rate_table/v29_16seed_cfg.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
MenuV29:
version: "V29"
menu_config: "configs/V29/rate_table/v29_16Seeds_Final_clean_cfg.yml"
table:
table_fname: "rates_16Seeds_Final"
table_outdir: "rates_tables/V29"
Loading
Loading