Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Menu Table into the new menu tools structure #68

Merged
merged 27 commits into from
Apr 15, 2024
Merged

Integrate Menu Table into the new menu tools structure #68

merged 27 commits into from
Apr 15, 2024

Conversation

danielhundhausen
Copy link
Collaborator

@danielhundhausen danielhundhausen commented Mar 23, 2024 •
edited
Loading

  • Integrates the menu table with the centrally defined object, utils etc.

Fixes implemented

  • "summed" objects in rate table (HT, MET etc.) now working, by adding one dimension after loading the cached arrays
  • Updated README/docs to include instructions on how to run / configure rate table. Could be more verbose but the crucial info is there.
  • Fix SeededConePuppiJet cuts, i.e. include online et>25 cut

danielhundhausen and others added 21 commits February 26, 2024 16:11
@danielhundhausen
roughtly move new rate tools to new structure
d2ae965
@danielhundhausen
remove old tool, run black
33cc075
@danielhundhausen
fix imports in new structure
506930f
@danielhundhausen
clean up!
394ba86
@danielhundhausen
more cleanup!
d5eac03
@danielhundhausen
continue refactoring of rate table
82f6ee1
@danielhundhausen
fix typing; bugs
f7794b0
@danielhundhausen
fix bug in regex substitution; variable referenced before assignment
f1f9b89
@danielhundhausen
add local index to return value from scaling application
31f2fbb
@danielhundhausen
fix logic of array operations
8353b75
@danielhundhausen
add PV as an object for menu table
5680aba
@danielhundhausen
set mass filed of array to 0 in scaling application
fde009e
@danielhundhausen
add debug output
ff42e0c
@danielhundhausen
fix bug where None values were removed from array; implement printing…
5507cd1 
… of table
@danielhundhausen
remove configurability of output dir from rate table config
d167c29
@danielhundhausen
cosmetic; remove debug output
7e76b1d
@danielhundhausen
fix bug in ANDing of cross masks
6448bd4
@danielhundhausen
minor fixes; printout of table after each seed
4a71396
@danielhundhausen
fix issues
9e4acbe
@danielhundhausen
Merge branch 'cms-l1-dpg:main' into port_menu_table
7de290d
@danielhundhausen
code quality
8ca75f4
@artlbv artlbv marked this pull request as draft March 23, 2024 19:49
@danielhundhausen danielhundhausen self-assigned this Mar 27, 2024
@danielhundhausen danielhundhausen requested a review from artlbv March 27, 2024 12:03
@danielhundhausen danielhundhausen marked this pull request as ready for review March 27, 2024 12:40
@artlbv
Copy link
Collaborator

artlbv commented Apr 15, 2024

Tested with V38 (PR to come)

@artlbv artlbv merged commit d6b6001 into cms-l1-dpg:main Apr 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artlbv artlbv Awaiting requested review from artlbv

Assignees

@danielhundhausen danielhundhausen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielhundhausen @artlbv