Backport of pull request #12 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hould be scoped. (#12) * For the CMS mutable member checker the hash for a field declaration should be scoped. This leads to reports for variables with the same name in different classes in the same translation unit getting the same hash. The output name of the report uses the hash so the last report was the only report for that variable. * Move to grouped Decl::'s remove Decl ending add Var
|
A new Pull Request was created by @gartung (Patrick Gartung) for branch cms/release/14.x/f28c006. @cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the CMS mutable member checker the hash for a field declaration should be scoped. This leads to reports for variables with the same name in different classes in the same translation unit getting the same hash. The output name of the report uses the hash so the last report was the only report for that variable.
Move to grouped Decl::'s remove Decl ending add Var