Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For the CMS mutable member checker the hash for a field declaration should be scoped. #12

Merged
merged 2 commits into from
Jun 4, 2023

Conversation

gartung
Copy link
Member

@gartung gartung commented Jun 3, 2023

This leads to reports for variables with the same name in different classes in the same translation unit getting the same hash. The output name of the report uses the hash so the last report was the only report for that variable.

…hould be scoped.

This leads to reports for variables with the same name in different
classes in the same translation unit getting the same hash. The output
name of the report uses the hash so the last report was the only report
for that variable.
@gartung gartung changed the title FFor the CMS mutable member checker the hash for a field declaration should be scoped. For the CMS mutable member checker the hash for a field declaration should be scoped. Jun 3, 2023
@cmsbuild
Copy link

cmsbuild commented Jun 3, 2023

A new Pull Request was created by @gartung (Patrick Gartung) for branch cms/release/16.x/464bda7.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link

cmsbuild commented Jun 3, 2023

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2f9ce7/32960/summary.html
COMMIT: 79dd005
CMSSW: CMSSW_13_2_X_2023-06-03-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-externals/llvm-project/12/32960/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

[3736/6082] /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/gcc/11.2.1-f9b9dfdd886f71cd63f5538223d8f161/bin/c++ -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-e26122adce53be773bc8b56dd72b2010/build/tools/clang/lib/CodeGen -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-e26122adce53be773bc8b56dd72b2010/llvm-16.0.3-bd1b99af77c08abf7a677e2ae688e57afd0f922f/clang/lib/CodeGen -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-e26122adce53be773bc8b56dd72b2010/llvm-16.0.3-bd1b99af77c08abf7a677e2ae688e57afd0f922f/clang/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-e26122adce53be773bc8b56dd72b2010/build/tools/clang/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-e26122adce53be773bc8b56dd72b2010/build/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-e26122adce53be773bc8b56dd72b2010/llvm-16.0.3-bd1b99af77c08abf7a677e2ae688e57afd0f922f/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -fno-strict-aliasing -O3 -DNDEBUG -std=c++17 -MD -MT tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/TargetInfo.cpp.o -MF tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/TargetInfo.cpp.o.d -o tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/TargetInfo.cpp.o -c /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-e26122adce53be773bc8b56dd72b2010/llvm-16.0.3-bd1b99af77c08abf7a677e2ae688e57afd0f922f/clang/lib/CodeGen/TargetInfo.cpp
[3737/6082] /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/gcc/11.2.1-f9b9dfdd886f71cd63f5538223d8f161/bin/c++ -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-e26122adce53be773bc8b56dd72b2010/build/tools/clang/lib/CodeGen -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-e26122adce53be773bc8b56dd72b2010/llvm-16.0.3-bd1b99af77c08abf7a677e2ae688e57afd0f922f/clang/lib/CodeGen -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-e26122adce53be773bc8b56dd72b2010/llvm-16.0.3-bd1b99af77c08abf7a677e2ae688e57afd0f922f/clang/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-e26122adce53be773bc8b56dd72b2010/build/tools/clang/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-e26122adce53be773bc8b56dd72b2010/build/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-e26122adce53be773bc8b56dd72b2010/llvm-16.0.3-bd1b99af77c08abf7a677e2ae688e57afd0f922f/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -fno-strict-aliasing -O3 -DNDEBUG -std=c++17 -MD -MT tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/CodeGenModule.cpp.o -MF tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/CodeGenModule.cpp.o.d -o tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/CodeGenModule.cpp.o -c /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-e26122adce53be773bc8b56dd72b2010/llvm-16.0.3-bd1b99af77c08abf7a677e2ae688e57afd0f922f/clang/lib/CodeGen/CodeGenModule.cpp
[3738/6082] /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/gcc/11.2.1-f9b9dfdd886f71cd63f5538223d8f161/bin/c++ -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-e26122adce53be773bc8b56dd72b2010/build/tools/clang/lib/Analysis -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-e26122adce53be773bc8b56dd72b2010/llvm-16.0.3-bd1b99af77c08abf7a677e2ae688e57afd0f922f/clang/lib/Analysis -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-e26122adce53be773bc8b56dd72b2010/llvm-16.0.3-bd1b99af77c08abf7a677e2ae688e57afd0f922f/clang/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-e26122adce53be773bc8b56dd72b2010/build/tools/clang/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-e26122adce53be773bc8b56dd72b2010/build/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-e26122adce53be773bc8b56dd72b2010/llvm-16.0.3-bd1b99af77c08abf7a677e2ae688e57afd0f922f/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -fno-strict-aliasing -O3 -DNDEBUG -std=c++17 -MD -MT tools/clang/lib/Analysis/CMakeFiles/obj.clangAnalysis.dir/ExprMutationAnalyzer.cpp.o -MF tools/clang/lib/Analysis/CMakeFiles/obj.clangAnalysis.dir/ExprMutationAnalyzer.cpp.o.d -o tools/clang/lib/Analysis/CMakeFiles/obj.clangAnalysis.dir/ExprMutationAnalyzer.cpp.o -c /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-e26122adce53be773bc8b56dd72b2010/llvm-16.0.3-bd1b99af77c08abf7a677e2ae688e57afd0f922f/clang/lib/Analysis/ExprMutationAnalyzer.cpp
[3739/6082] /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/gcc/11.2.1-f9b9dfdd886f71cd63f5538223d8f161/bin/c++ -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-e26122adce53be773bc8b56dd72b2010/build/tools/clang/lib/CodeGen -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-e26122adce53be773bc8b56dd72b2010/llvm-16.0.3-bd1b99af77c08abf7a677e2ae688e57afd0f922f/clang/lib/CodeGen -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-e26122adce53be773bc8b56dd72b2010/llvm-16.0.3-bd1b99af77c08abf7a677e2ae688e57afd0f922f/clang/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-e26122adce53be773bc8b56dd72b2010/build/tools/clang/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-e26122adce53be773bc8b56dd72b2010/build/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-e26122adce53be773bc8b56dd72b2010/llvm-16.0.3-bd1b99af77c08abf7a677e2ae688e57afd0f922f/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -fno-strict-aliasing -O3 -DNDEBUG -std=c++17 -MD -MT tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/CGBuiltin.cpp.o -MF tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/CGBuiltin.cpp.o.d -o tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/CGBuiltin.cpp.o -c /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-e26122adce53be773bc8b56dd72b2010/llvm-16.0.3-bd1b99af77c08abf7a677e2ae688e57afd0f922f/clang/lib/CodeGen/CGBuiltin.cpp
ninja: build stopped: subcommand failed.
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.6HFQBQ (%build)


RPM build errors:
line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: external+llvm+16.0.3-e26122adce53be773bc8b56dd72b2010
Macro expanded in comment on line 350: %{pkginstroot}/lib64


@cmsbuild
Copy link

cmsbuild commented Jun 3, 2023

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2f9ce7/32961/summary.html
COMMIT: 79dd005
CMSSW: CMSSW_13_2_X_2023-06-03-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-externals/llvm-project/12/32961/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

[3733/6082] /build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/gcc/11.2.1-f9b9dfdd886f71cd63f5538223d8f161/bin/c++ -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-5a6198efa6faecb85626b3d66daad70c/build/tools/clang/lib/CodeGen -I/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-5a6198efa6faecb85626b3d66daad70c/llvm-16.0.3-bd1b99af77c08abf7a677e2ae688e57afd0f922f/clang/lib/CodeGen -I/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-5a6198efa6faecb85626b3d66daad70c/llvm-16.0.3-bd1b99af77c08abf7a677e2ae688e57afd0f922f/clang/include -I/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-5a6198efa6faecb85626b3d66daad70c/build/tools/clang/include -I/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-5a6198efa6faecb85626b3d66daad70c/build/include -I/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-5a6198efa6faecb85626b3d66daad70c/llvm-16.0.3-bd1b99af77c08abf7a677e2ae688e57afd0f922f/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -fno-strict-aliasing -O3 -DNDEBUG -std=c++17 -MD -MT tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/CodeGenModule.cpp.o -MF tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/CodeGenModule.cpp.o.d -o tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/CodeGenModule.cpp.o -c /build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-5a6198efa6faecb85626b3d66daad70c/llvm-16.0.3-bd1b99af77c08abf7a677e2ae688e57afd0f922f/clang/lib/CodeGen/CodeGenModule.cpp
[3734/6082] /build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/gcc/11.2.1-f9b9dfdd886f71cd63f5538223d8f161/bin/c++ -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-5a6198efa6faecb85626b3d66daad70c/build/tools/clang/lib/CodeGen -I/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-5a6198efa6faecb85626b3d66daad70c/llvm-16.0.3-bd1b99af77c08abf7a677e2ae688e57afd0f922f/clang/lib/CodeGen -I/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-5a6198efa6faecb85626b3d66daad70c/llvm-16.0.3-bd1b99af77c08abf7a677e2ae688e57afd0f922f/clang/include -I/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-5a6198efa6faecb85626b3d66daad70c/build/tools/clang/include -I/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-5a6198efa6faecb85626b3d66daad70c/build/include -I/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-5a6198efa6faecb85626b3d66daad70c/llvm-16.0.3-bd1b99af77c08abf7a677e2ae688e57afd0f922f/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -fno-strict-aliasing -O3 -DNDEBUG -std=c++17 -MD -MT tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/TargetInfo.cpp.o -MF tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/TargetInfo.cpp.o.d -o tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/TargetInfo.cpp.o -c /build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-5a6198efa6faecb85626b3d66daad70c/llvm-16.0.3-bd1b99af77c08abf7a677e2ae688e57afd0f922f/clang/lib/CodeGen/TargetInfo.cpp
[3735/6082] /build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/gcc/11.2.1-f9b9dfdd886f71cd63f5538223d8f161/bin/c++ -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-5a6198efa6faecb85626b3d66daad70c/build/tools/clang/lib/Analysis -I/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-5a6198efa6faecb85626b3d66daad70c/llvm-16.0.3-bd1b99af77c08abf7a677e2ae688e57afd0f922f/clang/lib/Analysis -I/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-5a6198efa6faecb85626b3d66daad70c/llvm-16.0.3-bd1b99af77c08abf7a677e2ae688e57afd0f922f/clang/include -I/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-5a6198efa6faecb85626b3d66daad70c/build/tools/clang/include -I/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-5a6198efa6faecb85626b3d66daad70c/build/include -I/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-5a6198efa6faecb85626b3d66daad70c/llvm-16.0.3-bd1b99af77c08abf7a677e2ae688e57afd0f922f/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -fno-strict-aliasing -O3 -DNDEBUG -std=c++17 -MD -MT tools/clang/lib/Analysis/CMakeFiles/obj.clangAnalysis.dir/ExprMutationAnalyzer.cpp.o -MF tools/clang/lib/Analysis/CMakeFiles/obj.clangAnalysis.dir/ExprMutationAnalyzer.cpp.o.d -o tools/clang/lib/Analysis/CMakeFiles/obj.clangAnalysis.dir/ExprMutationAnalyzer.cpp.o -c /build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-5a6198efa6faecb85626b3d66daad70c/llvm-16.0.3-bd1b99af77c08abf7a677e2ae688e57afd0f922f/clang/lib/Analysis/ExprMutationAnalyzer.cpp
[3736/6082] /build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/gcc/11.2.1-f9b9dfdd886f71cd63f5538223d8f161/bin/c++ -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-5a6198efa6faecb85626b3d66daad70c/build/tools/clang/lib/CodeGen -I/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-5a6198efa6faecb85626b3d66daad70c/llvm-16.0.3-bd1b99af77c08abf7a677e2ae688e57afd0f922f/clang/lib/CodeGen -I/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-5a6198efa6faecb85626b3d66daad70c/llvm-16.0.3-bd1b99af77c08abf7a677e2ae688e57afd0f922f/clang/include -I/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-5a6198efa6faecb85626b3d66daad70c/build/tools/clang/include -I/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-5a6198efa6faecb85626b3d66daad70c/build/include -I/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-5a6198efa6faecb85626b3d66daad70c/llvm-16.0.3-bd1b99af77c08abf7a677e2ae688e57afd0f922f/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -fno-strict-aliasing -O3 -DNDEBUG -std=c++17 -MD -MT tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/CGBuiltin.cpp.o -MF tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/CGBuiltin.cpp.o.d -o tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/CGBuiltin.cpp.o -c /build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/llvm/16.0.3-5a6198efa6faecb85626b3d66daad70c/llvm-16.0.3-bd1b99af77c08abf7a677e2ae688e57afd0f922f/clang/lib/CodeGen/CGBuiltin.cpp
ninja: build stopped: subcommand failed.
error: Bad exit status from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.q1CtLj (%build)


RPM build errors:
line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: external+llvm+16.0.3-5a6198efa6faecb85626b3d66daad70c
Macro expanded in comment on line 350: %{pkginstroot}/lib64


@cmsbuild
Copy link

cmsbuild commented Jun 4, 2023

Pull request #12 was updated.

@gartung gartung force-pushed the gartung-getIssueHash-fix branch from fde7014 to 67fa9ea Compare June 4, 2023 00:08
@cmsbuild
Copy link

cmsbuild commented Jun 4, 2023

Pull request #12 was updated.

@gartung
Copy link
Member Author

gartung commented Jun 4, 2023

please test

@cmsbuild
Copy link

cmsbuild commented Jun 4, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2f9ce7/32962/summary.html
COMMIT: 67fa9ea
CMSSW: CMSSW_13_2_X_2023-06-03-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-externals/llvm-project/12/32962/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 10 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3221457
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3221429
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@gartung gartung merged commit 8d7c2f5 into cms/release/16.x/464bda7 Jun 4, 2023
gartung added a commit that referenced this pull request Jun 4, 2023
…hould be scoped. (#12)

* For the CMS mutable member checker the hash for a field declaration should be scoped.
This leads to reports for variables with the same name in different
classes in the same translation unit getting the same hash. The output
name of the report uses the hash so the last report was the only report
for that variable.

* Move to grouped Decl::'s remove Decl ending add Var
@gartung gartung deleted the gartung-getIssueHash-fix branch June 4, 2023 15:43
gartung added a commit that referenced this pull request Jun 4, 2023
…hould be scoped. (#12) (#13)

* For the CMS mutable member checker the hash for a field declaration should be scoped.
This leads to reports for variables with the same name in different
classes in the same translation unit getting the same hash. The output
name of the report uses the hash so the last report was the only report
for that variable.

* Move to grouped Decl::'s remove Decl ending add Var
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants