-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix charge info in 1200,1600,2000 GeV HIP files #12
Conversation
type bugfix |
A new Pull Request was created by @tvami (Tamas Vami) for branch master. @SiewYan, @smuzaffar, @mkirsano, @aandvalenzuela, @iarspider, @Saptaparna, @cmsbuild, @alberto-sanchez, @menglu21, @GurpreetSinghChahal can you please review it and eventually sign? Thanks. |
@cmsbuild , please test |
+1 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e39d6d/32107/summary.html Comparison SummarySummary:
|
hi @perrotta @rappoccio can we merge this in master before the 2300 IB? I'd like to make the backport to 10_6_X so we can discuss it in tomorrow's meeting. |
+externals |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
I found a typo in the charge determination, HIP3 has not 3 charge and HIP6 has now 6 charge.
Please note these are changes in the comments, so it was not very obvious that those are relevant... After local tests it seems they are!