Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix charge info in 1200,1600,2000 GeV HIP files #12

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Apr 24, 2023

I found a typo in the charge determination, HIP3 has not 3 charge and HIP6 has now 6 charge.

Please note these are changes in the comments, so it was not very obvious that those are relevant... After local tests it seems they are!

@tvami
Copy link
Contributor Author

tvami commented Apr 24, 2023

type bugfix

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tvami (Tamas Vami) for branch master.

@SiewYan, @smuzaffar, @mkirsano, @aandvalenzuela, @iarspider, @Saptaparna, @cmsbuild, @alberto-sanchez, @menglu21, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented Apr 24, 2023

@cmsbuild , please test

@Saptaparna
Copy link

+1

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e39d6d/32107/summary.html
COMMIT: ea0f17e
CMSSW: CMSSW_13_1_X_2023-04-24-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/Configuration-Generator/12/32107/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 25 lines from the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3460685
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3460654
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor Author

tvami commented Apr 24, 2023

hi @perrotta @rappoccio can we merge this in master before the 2300 IB? I'd like to make the backport to 10_6_X so we can discuss it in tomorrow's meeting.

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants