Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix charge typo for Q=1 tau-prime #11

Merged
merged 1 commit into from
Apr 16, 2023
Merged

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Apr 16, 2023

Found a typo in #10
Charges are measured in quark charges, so for Q=1e it should have been 3

@tvami
Copy link
Contributor Author

tvami commented Apr 16, 2023

@perrotta sorry I found a typo in the prev PR, this should fix that.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tvami (Tamas Vami) for branch master.

@SiewYan, @smuzaffar, @mkirsano, @aandvalenzuela, @iarspider, @Saptaparna, @cmsbuild, @alberto-sanchez, @menglu21, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@perrotta
Copy link

+orp

  • Quite reasonable fix

@Saptaparna
Copy link

+1

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests.

@tvami
Copy link
Contributor Author

tvami commented Apr 16, 2023

@cmsbuild , please test

  • it doesnt do anything but it seems we need to do it for the merge?

@smuzaffar
Copy link
Contributor

orp has signed it, so lete merge it and include it for next 13.1.X IB

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-db6175/31992/summary.html
COMMIT: 2dc2eef
CMSSW: CMSSW_13_1_X_2023-04-16-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/Configuration-Generator/11/31992/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 11 lines from the logs
  • Reco comparison results: 16 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3459609
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3459578
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants