Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine file path in syntax error of parser_test.go #139

Merged

Conversation

apstndb
Copy link
Contributor

@apstndb apstndb commented Oct 16, 2024

This PR fixes syntax error message and parser_test.go to make error message can be treated as a hyperlink to file position in some software(e.g. Goland).

スクリーンショット 2024-10-16 13 12 42

fixes #138

@apstndb apstndb changed the title Feature/linkable syntax error Refine file path in syntax error of parser_test.go Oct 16, 2024
@apstndb apstndb force-pushed the feature/linkable-syntax-error branch from 4910422 to c6cbfff Compare October 16, 2024 05:50
@apstndb
Copy link
Contributor Author

apstndb commented Oct 16, 2024

I have rebased beause it contained commits in another branch

Copy link
Collaborator

@makenowjust makenowjust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@makenowjust makenowjust merged commit 48e607c into cloudspannerecosystem:main Oct 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make error of parse_test.go jumpable
2 participants