Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make error of parse_test.go jumpable #138

Closed
apstndb opened this issue Oct 16, 2024 · 0 comments · Fixed by #139
Closed

Make error of parse_test.go jumpable #138

apstndb opened this issue Oct 16, 2024 · 0 comments · Fixed by #139

Comments

@apstndb
Copy link
Contributor

apstndb commented Oct 16, 2024 •
edited
Loading

Current error of parser_test.go can't be treated as hyperlink to the file position.

  • token.File.FilePath is not a full path
  • error message have no following whitespace before FilePath.

This is fixable and may be useful outside of testing as well.

Current

スクリーンショット 2024-10-16 12 56 33

Proposed

スクリーンショット 2024-10-16 12 57 20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refine file path in syntax error of parser_test.go apstndb/memefish
1 participant
@apstndb