Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Terraform cloudposse/s3-bucket/aws to v2 #72

Merged
merged 2 commits into from
Aug 31, 2022

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 21, 2022

Mend Renovate

This PR contains the following updates:

Package Type Update Change
cloudposse/s3-bucket/aws (source) module major 0.49.0 -> 2.0.3

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox. ⚠ Warning: custom changes will be lost.

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested review from a team as code owners April 21, 2022 04:11
@renovate renovate bot requested review from Makeshift and joe-niland April 21, 2022 04:11
@renovate renovate bot added the auto-update This PR was automatically generated label Apr 21, 2022
Copy link

@cloudposse-mergebot cloudposse-mergebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've automatically approved this PR because the checks from the automated Pull Request have passed.

@Nuru Nuru self-requested a review May 1, 2022 22:51
Copy link
Contributor

@Nuru Nuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold for v3 release of this module

@luanbonln
Copy link

When this PR will be merged to master?

@wosiu
Copy link

wosiu commented Aug 31, 2022

We're getting deprecation warnings in many places because of this.
Related issues:
cloudposse/terraform-aws-lb-s3-bucket#55
#74

v.2.0.1 at least is needed for those though.

@Nuru Nuru added the no-release Do not create a new release (wait for additional code changes) label Aug 31, 2022
@Nuru Nuru requested review from Nuru and removed request for Makeshift August 31, 2022 21:07
Copy link
Contributor

@Nuru Nuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as a patch. People still need to take care upgrading, and a better upgrade path will be available once Terraform 1.3 is released.

@mergify mergify bot merged commit 522b4b4 into master Aug 31, 2022
@mergify mergify bot deleted the renovate/cloudposse-s3-bucket-aws-2.x branch August 31, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update This PR was automatically generated no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants