Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warnings - bump cloudposse/s3-log-storage/aws to 0.28.2 #55

Closed
mwos-sl opened this issue Aug 31, 2022 · 1 comment · Fixed by #60
Closed

Deprecation warnings - bump cloudposse/s3-log-storage/aws to 0.28.2 #55

mwos-sl opened this issue Aug 31, 2022 · 1 comment · Fixed by #60
Labels
bug 🐛 An issue with the system

Comments

@mwos-sl
Copy link

mwos-sl commented Aug 31, 2022

I'm getting deprecation warnings:

│ Warning: Argument is deprecated
│
│   with module.alb-logs.module.s3_bucket.module.aws_s3_bucket.aws_s3_bucket.default,
│   on .terraform/modules/alb-logs.s3_bucket.aws_s3_bucket/main.tf line 30, in resource "aws_s3_bucket" "default":
│   30: resource "aws_s3_bucket" "default" {
│
│ Use the top-level parameter object_lock_enabled and the aws_s3_bucket_object_lock_configuration resource instead

Related to downstream: cloudposse/terraform-aws-s3-log-storage#74
The above has to be done first, then this: https://github.com/cloudposse/terraform-aws-lb-s3-bucket/blob/master/main.tf#L63
has to be bumped after aws-s3-log-storage is released.

New cloudposse/s3-log-storage/aws is already released under 0.28.2

Versions

terraform 1.0.7
aws provider 4.27.0
cloudposse/lb-s3-bucket/aws 0.16.0

@mwos-sl mwos-sl added the bug 🐛 An issue with the system label Aug 31, 2022
@mwos-sl mwos-sl changed the title Deprecation warnings Deprecation warnings - bump cloudposse/s3-log-storage/aws to 0.28.2 Sep 2, 2022
@wosiu
Copy link

wosiu commented Sep 2, 2022

There is a new release cloudposse/s3-log-storage/aws, version should be bumped here from 0.28.0 to 0.28.2, to include transitive upstream dependancy update (cloudposse/s3-bucket to 2.0.1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An issue with the system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants