Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert master to v0.18.4 (current GA release) #90

Merged
merged 9 commits into from
Jul 11, 2022
Merged

Revert master to v0.18.4 (current GA release) #90

merged 9 commits into from
Jul 11, 2022

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Jul 11, 2022

what

  • Revert main to v0.18.4

why

  • PR feat: use security-group module instead of resource #73 converted this module to use an experimental and since abandoned version of the security group module. This was published as version 0.19.0. 0.18.4 was the last version published before that modification, and the last supported version. This PR reverts the master branch to version 0.18.4 in preparation for providing a compatible version 1.0 of this module using security group module v2.0.

@Nuru Nuru added the no-release Do not create a new release (wait for additional code changes) label Jul 11, 2022
Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bridgecrew has found errors in this PR ⬇️

module "security_group" {
source = "cloudposse/security-group/aws"
version = "0.3.3"
resource "aws_security_group" "default" {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOW   Ensure Security Groups are attached to EC2 instances or ENIs
    Resource: aws_security_group.default | ID: BC_AWS_NETWORKING_51

How to Fix

resource "aws_network_interface" "test" {
  subnet_id       = "aws_subnet.public_a.id"
  security_groups = [aws_security_group.ok_sg.id]
}

resource "aws_instance" "test" {
  ami           = "data.aws_ami.ubuntu.id"
  instance_type = "t3.micro"
  security_groups = [aws_security_group.ok_sg.id]
}

resource "aws_security_group" "ok_sg" {
  ingress {
    description = "TLS from VPC"
    from_port   = 443
    to_port     = 443
    protocol    = "tcp"
    cidr_blocks = 0.0.0.0/0
  }
}

Description

A check to ensure that orphaned Security groups aren't created. Elastic Network Interfaces (ENIs). This checks that Security Groups are attached to provisioning resources.

@Nuru Nuru requested review from a team as code owners July 11, 2022 21:15
@Nuru Nuru requested review from jhosteny and florian0410 July 11, 2022 21:15
@Nuru Nuru merged commit e4c7e80 into master Jul 11, 2022
@Nuru Nuru deleted the revert-sg branch July 11, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants