Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use permissions boundary on the default roles #85

Merged
merged 4 commits into from
Feb 9, 2022

Conversation

0xVox
Copy link
Contributor

@0xVox 0xVox commented Feb 8, 2022

what

  • Allow the use of a permissions boundary on the default role

why

  • In our organisation, permissions boundaries are a requirement for all engineers to provide to roles. Allowing them to be attached to the default roles allows us to create node groups without creating our own roles and policies.

  • The change is entirely optional and non-breaking.

references

  • The eks_cluster module you provide also allows this.

@0xVox 0xVox requested review from a team as code owners February 8, 2022 12:14
@0xVox 0xVox requested review from srhopkins and woz5999 February 8, 2022 12:14
Gowiem
Gowiem previously requested changes Feb 8, 2022
Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change, but other will be good to merge. Update and I'll review.

variables.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
@mergify mergify bot dismissed Gowiem’s stale review February 8, 2022 19:20

This Pull Request has been updated, so we're dismissing all reviews.

@Gowiem
Copy link
Member

Gowiem commented Feb 9, 2022

/test all

@Gowiem
Copy link
Member

Gowiem commented Feb 9, 2022

Thanks for the assist @nitrocode 👍 -- I need to remember that I can do that for simple changes like I mentioned.

@Gowiem Gowiem merged commit ea1c1bc into cloudposse:master Feb 9, 2022
@0xVox
Copy link
Contributor Author

0xVox commented Feb 10, 2022

Thanks all :)

Nuru added a commit that referenced this pull request Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants