-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ARP] Add tas-runtime-bot as a bot #367
Conversation
cc @ameowlia |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mkocher Hmm, I don't think we actually defined the approval process for WG bots when #317 introduced the role and the automation supporting it. In terms of permissions, they're equivalent to an approver across all the WG areas, so from RFC 0008 admitting one seems like the decision of the WG leads, with the TOC overriding at its discretion. I'm adding this topic to the TOC agenda for tomorrow for discussion. Should we have a TAS-associated bot with that level of access to a CFF WG and all its repos, though? |
Amelia has already approved this PR, but is currently OOO. If this decision is under her purview then it seems like the decision has been made in the positive, right? Ordinarily we could just wait for her to return, but given the upcoming non-standard GH teams removal we want to get this in sooner rather than later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔑 Most of the current ARP CI uses this bot's credentials to interact with ARP's GitHub repos.
👎 The bot currently gets its access from the
runtime
team, which will likely be deleted when #262 is implemented.➡️ Bring the bot account into the fold as a working group bot.