Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARP] Add tas-runtime-bot as a bot #367

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Conversation

ctlong
Copy link
Member

@ctlong ctlong commented Jul 20, 2022

🔑 Most of the current ARP CI uses this bot's credentials to interact with ARP's GitHub repos.

👎 The bot currently gets its access from the runtime team, which will likely be deleted when #262 is implemented.

➡️ Bring the bot account into the fold as a working group bot.

@ctlong ctlong changed the title Add tas-runtime-bot as a ARP WG bot [ARP] Add tas-runtime-bot as a bot Jul 20, 2022
@ctlong
Copy link
Member Author

ctlong commented Jul 20, 2022

cc @ameowlia

@ameowlia ameowlia self-requested a review July 22, 2022 17:45
Copy link
Member

@ameowlia ameowlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkocher
Copy link
Member

mkocher commented Aug 1, 2022

@emalm are you able to merge this for us or tell us what we need to do to get it merged? We'll have the same question for #377 as well.

@emalm
Copy link
Member

emalm commented Aug 2, 2022

@mkocher Hmm, I don't think we actually defined the approval process for WG bots when #317 introduced the role and the automation supporting it. In terms of permissions, they're equivalent to an approver across all the WG areas, so from RFC 0008 admitting one seems like the decision of the WG leads, with the TOC overriding at its discretion. I'm adding this topic to the TOC agenda for tomorrow for discussion.

Should we have a TAS-associated bot with that level of access to a CFF WG and all its repos, though?

@stephanme
Copy link
Contributor

#333 + #375 + #378 introduce WG area reviewers and WG area bots. Still WIP.
If accepted, RFC-0008 needs a replacement similar to #375 for RFC-0005.

@ctlong
Copy link
Member Author

ctlong commented Aug 2, 2022

admitting [a bot] seems like the decision of the WG leads, with the TOC overriding at its discretion

Amelia has already approved this PR, but is currently OOO. If this decision is under her purview then it seems like the decision has been made in the positive, right? Ordinarily we could just wait for her to return, but given the upcoming non-standard GH teams removal we want to get this in sooner rather than later.

@emalm emalm self-requested a review August 19, 2022 20:26
Copy link
Member

@emalm emalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve these changes in the interest of keeping teams unblocked when #387 gets merged soon. Once we resolve #386 to establish better guidelines about bot account management, though, we should review all the bots with permissions within WGs or areas.

@emalm emalm merged commit f0a8997 into cloudfoundry:main Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants