[RFC] Formally track aspiring approvers as reviewers

[rkoster]

Extend the working group yaml defenitions to optionally include a reviewers key with a list of contributors who like to become approvers.
The github org automation should use this information to create a github team for the area with -reviewers suffix and read permissions.

This will later allow automatic assignment of PRs to be reviewed, which will help these contributors more easily statisfy the requirments to become approvers.

This PR formalizes the pattern introduced in: #324

[stephanme]

We need to mention or extend toc/rfc/rfc-0008-role-change-process.md, i.e. how would a contributor gain reviewers role.

I guess the process will be similar as for promotion to contributor:

• pre-requisite: user is contributor and files a PR
• 2 existing approvers review the PR with +1
• WG lead will merge or close

[emalm]

@cloudfoundry/wg-leads Could some of you please weigh in about whether you would find this Reviewers role valuable for your working groups, or about any concerns around granting read permissions to the few private repos that may be within your working group's scope? Thanks!

[pivotal-marcela-campo]

I do think it is useful to help contributors get approver status. It provides an standardised way of assigning reviews and following up on that within the PR to make sure the review gets done before merging.

[stephanme]

A use case discussed in CAPI Open Office Hour: Reviewers role can also be used to grant read access to Concourse pipelines of a WG area that the team doesn't want to make publicly accessible (e.g. due to risk of revealing credentials in the build logs).

[stephanme]

Q: Should reviewers be part of the team wg-[WORKING-GROUP-NAME]?

https://github.com/cloudfoundry/community/blob/main/toc/rfc/rfc-0005-github-teams-and-access.md as of today would exclude them (membership: All approvers and leads for a WG). The intended use case for the WG global team (for organization and tagging) suggests to add them. There are no repo permissions granted by this team.

[ameowlia]

Yes, the ARP working group would like to have reviewer teams. This way I can automatically assign PRs to these teams and aspiring approvers will be able to easily get "points" to become an approver.

[emalm]

TOC voted today to start the final comment period on this RFC, concluding August 2.