Drop constraint quota_definitions_name_key

[kathap]

On the name column in quota_defintions there were two unique constraints/indexes. One unique index with name qd_name_index, which is similar in postgres and mysql, and then an unique constraint on column name with name in postgres=quota_definitions_name_key and name in mysql=name. These index/constraint are created during table creation:

    create_table :quota_definitions do
      VCAP::Migration.common(self, :qd)

      String :name, null: false, unique: true, case_insensitive: true
      Boolean :non_basic_services_allowed, null: false
      Integer :total_services, null: false
      Integer :memory_limit, null: false

      index :name, unique: true
    end

The unique: true in line String :name, null: false, unique: true, case_insensitive: true creates the unique constraint.
Since there is an unique index created on column name index :name, unique: true (later renamed to qd_name_index), we don't need the unique constraint. Dropping it with this migration.

• I have reviewed the contributing guide

• I have viewed, signed, and submitted the Contributor License Agreement

• I have made this pull request to the main branch

• I have run all the unit tests using bundle exec rake

• I have run CF Acceptance Tests

[svkrieger]

Can you please add tests for the migration to make sure it does what it should and that it is idempotent?
Example: https://github.com/cloudfoundry/cloud_controller_ng/blob/main/spec/migrations/20240820070742_add_jobs_user_guid_state_index_spec.rb

[kathap]

corrupt branch