Prevent 500 on parallel object creation #3918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kathap
force-pushed
the
prevent-500-on-parallel-object-creation
branch
2 times, most recently
from
9c76c97 to
b636892
Compare
5 tasks
While fixing #3899, we found further possible occurrences of 500 errors in severel _create actions when doing parallel requests. In this PR we want to address them by adding an around_save to the corresponding model in which we catch Sequel::UniqueConstraintViolation errors for the case when ne POST bypasses the other one and inserts the record into the db after the first POST has passed the validate function but before the actual insert.
kathap
force-pushed
the
prevent-500-on-parallel-object-creation
branch
from
d5e3683 to
fea4efb
Compare
svkrieger
reviewed
Aug 14, 2024
There was a problem hiding this comment.
Looks great! Just a question about mocking in two tests and a minor finding.
EDIT: Also do we plan to get rid of the unique checks in the coding? If we catch the unique constraint errors thrown by the DB reliably now, it should not be necessary to check for uniqueness beforehand.
spec/unit/actions/service_credential_binding_app_create_spec.rb
Outdated
Show resolved
Hide resolved
spec/unit/actions/service_credential_binding_app_create_spec.rb
Outdated
Show resolved
Hide resolved
svkrieger
requested changes
Aug 19, 2024
spec/unit/actions/service_credential_binding_app_create_spec.rb
Outdated
Show resolved
Hide resolved
spec/unit/actions/service_credential_binding_app_create_spec.rb
Outdated
Show resolved
Hide resolved
spec/unit/actions/service_credential_binding_key_create_spec.rb
Outdated
Show resolved
Hide resolved
svkrieger
approved these changes
Aug 19, 2024
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Aug 22, 2024
Changes in cloud_controller_ng:
- Prevent 500 on parallel object creation
PR: cloudfoundry/cloud_controller_ng#3918
Author: kathap <[email protected]>
svkrieger
pushed a commit
that referenced
this pull request
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While fixing #3899, we found further possible occurrences of 500 errors in severel _create actions when doing parallel requests. In this PR we want to address them by adding an around_save to the corresponding model in which we catch Sequel::UniqueConstraintViolation errors for the case when ne POST bypasses the other one and inserts the record into the db after the first POST has passed the validate function but before the actual insert.
A short explanation of the proposed change:
Adding an around_save to the corresponding model in which we catch Sequel::UniqueConstraintViolation errors for the case when ne POST bypasses the other one and inserts the record into the db after the first POST has passed the validate function but before the actual insert
An explanation of the use cases your change solves
No more 500 errors on parallel request execution
Links to any other associated PRs
Prevent 500 on parallel service instance creation #3899
Prevent 500 on parallel org quota creation #3924
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests