Add option to check for deprecated stacks in pre-start rake task #3894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaopapereira
approved these changes
Jul 25, 2024
updated, thanks! Co-authored-by: João Pereira <[email protected]>
Samze
reviewed
Jul 26, 2024
| } | ||
| end | ||
|
|
||
| describe 'the deprecated stack is in the db' do |
There was a problem hiding this comment.
question Do we need these describes for the db behaviour? Looking at the code, if the deprecated stack is in the stacks list we don't even check the DB. We return early here https://github.com/cloudfoundry/cloud_controller_ng/pull/3894/files#diff-b51e853460880f38ea614d45c335bfdaa98ebf81f6166ce4c13ffab95bfbf871R23
Samze
reviewed
Jul 26, 2024
| end | ||
| end | ||
|
|
||
| describe 'the deprecated stack is not in the db' do |
There was a problem hiding this comment.
Samze
reviewed
Jul 26, 2024
tcdowney
reviewed
Jul 30, 2024
Samze
approved these changes
Jul 31, 2024
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Jul 31, 2024
Changes in cloud_controller_ng:
- Add option to check for deprecated stacks in pre-start rake task
PR: cloudfoundry/cloud_controller_ng#3894
Author: Alex Rocha <[email protected]>
Author: João Pereira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional check to ensure operators can upgrade without hanging dependencies to old or unwanted stacks
Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests