DB encryption key loaded incorrectly in DB migration

[xandroc]

Thanks for submitting an issue to cloud_controller_ng. We are always trying to improve! To help us, please fill out the following template.

Issue

db.rake and dbmigrator use old method of loading the db encryption key.

VCAP::CloudController::Encryptor.db_encryption_key = RakeConfig.config.get(:db_encryption_key)

Context

To ensure full db encryption key setup db key load should happen like it does in, @config.configure_components should be called on db connection.

      Encryptor.db_encryption_key = get(:db_encryption_key)

      if get(:database_encryption)
        Encryptor.database_encryption_keys = get(:database_encryption)[:keys]
        Encryptor.current_encryption_key_label = get(:database_encryption)[:current_key_label]
        Encryptor.pbkdf2_hmac_iterations = get(:database_encryption)[:pbkdf2_hmac_iterations]
      end

@Samze discovered this here, verified by @tcdowney, details in link

Steps to Reproduce

Expected result

Update db.rake and dbmigrator to use correct db encryption setup

Current result

Deprecated way of loading key is used

[include relevant logs]

Possible Fix

A helper method def load_db_encryption_key was included in config as part of the PR where this issue was found that can be used to set up db encryption.

name of issue screenshot

[if relevant, include a screenshot]