Reduce queries to DB when collecting routing info #3813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svkrieger
force-pushed
the
improve-routing-info-collection
branch
from
44756c3 to
4bd0658
Compare
Previously there were many DB queries when e.g. adding a destination to a route. There were as many queries as route_mappings existed for the process (destination). Further queries then fetched associated routes, domains and route_bindings each in their own query. With this change all those resources are fetched via eager loading, which results in one query per DB table, in this case 5.
svkrieger
force-pushed
the
improve-routing-info-collection
branch
from
4bd0658 to
0dcba6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
Previously there were many DB queries when e.g. adding a destination to a route. There were as many queries as route_mappings existed for the process (destination). Further queries then fetched associated routes, domains and route_bindings each in their own query. With this change all those resources are fetched via eager loading, which results in one query per DB table, in this case 5.
Links to any other associated PRs
Implemented performance tests for adding a destination to an app with many route mappings: cloudfoundry/cf-performance-tests#34
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests