Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add destinations performance tests #34

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

svkrieger
Copy link
Contributor

@svkrieger svkrieger commented May 21, 2024

Adding performance tests for POST, PATCH, DELETE /v3/routes/:guid/destinations.

Diego seems to have a limitation somewhere between 750 and 800 routes per app. At least the app does not start anymore if I create 800 route mappings. With 10000 route mappings the staging already failed.

@svkrieger svkrieger force-pushed the add-destinations-perf-test branch from 0bcd2c2 to 145406e Compare May 21, 2024 11:54
@svkrieger svkrieger marked this pull request as ready for review May 21, 2024 11:57
@svkrieger svkrieger force-pushed the add-destinations-perf-test branch 4 times, most recently from 987b0e7 to a82ea9b Compare May 27, 2024 12:54
Copy link
Contributor

@jochenehret jochenehret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only a few minor issues.

destinations/v1/destinations_suite_test.go Outdated Show resolved Hide resolved
helpers/database.go Show resolved Hide resolved
scripts/pgsql_functions.tmpl.sql Show resolved Hide resolved
destinations/v1/destinations_suite_test.go Outdated Show resolved Hide resolved
destinations/v1/destinations_suite_test.go Outdated Show resolved Hide resolved
@svkrieger svkrieger force-pushed the add-destinations-perf-test branch 2 times, most recently from c23c4cd to cf4742f Compare May 29, 2024 12:09
@svkrieger svkrieger force-pushed the add-destinations-perf-test branch from cf4742f to 47607b0 Compare May 29, 2024 12:12
@svkrieger svkrieger requested a review from jochenehret May 29, 2024 12:13
@svkrieger svkrieger merged commit d9be324 into main May 29, 2024
1 check passed
@svkrieger svkrieger deleted the add-destinations-perf-test branch May 29, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants