Add validation for resource match mode #3414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 29, 2023
FloThinksPi
force-pushed
the
fix-mode-posix-permission
branch
from
f141934 to
6da720a
Compare
If provided, the 'mode' field (resource match object) must be a string.
Without this fix a request to /v3/resource_matches with
{ .. "mode": 644 .. }
resulted in an UnknownError. Now the error message
"array contains at least one resource with a non-string mode"
is returned instead.
Furthermore the format is checked and if the provided value is not a
POSIX mode string (*), the following error message is returned:
"array contains at least one resource with an incorrect mode"
(*) A simple regex only allowing digits from 0 to 7 is used. At least 1
digit must be provided.
Co-authored-by: Florian Braun <[email protected]>
philippthun
force-pushed
the
fix-mode-posix-permission
branch
from
6da720a to
0771dda
Compare
philippthun
changed the title
philippthun
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If provided, the
modefield (resource match object) must be a string. Without this fix a request to/v3/resource_matcheswithresulted in an
UnknownError. Now the error messageis returned instead.
Furthermore the format is checked and if the provided value is not a POSIX mode string (*), the following error message is returned:
(*) A simple regex only allowing digits from 0 to 7 is used. At least 1 digit must be provided.
See also #3329 and #3409.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests