-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Add validation for resource match mode" #3409
Conversation
This reverts commit 22e2122 due to the mode limitation to 3-4 characters beeing against the POSIX Standard as it defines 9 permission bits and 3 file bits with no limit for more bits. As the documentation is not specific on the further limitations the currently implemented validation is incorrect. See also: https://en.wikipedia.org/wiki/Unix_file_types#Numeric https://pubs.opengroup.org/onlinepubs/9699919799/
Findings on the API:
That means e.g. POSXI Permissions 100700 = 0700 = 07. |
Closed in favour of #3414 |
Lets do a revert for the short term fix, we are not sure how exactly the forward code fix should look like, likely needs more time and this should be gone in the next capi release for sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to revert it for now and implement a more loose validation, to not break officially supported clients.
This reverts commit 22e2122 due to the mode limitation to 3-4 characters beeing against the POSIX Standard as it defines 9 permission bits and 3 file bits with no limit for more bits. As the documentation is not specific on the further limitations the currently implemented validation is incorrect.
See also:
https://en.wikipedia.org/wiki/Unix_file_types#Numeric
https://pubs.opengroup.org/onlinepubs/9699919799/
#3329
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
main
branchI have run all the unit tests using
bundle exec rake
I have run CF Acceptance Tests