Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor service_instance_list_fetcher perm logic #3014

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Refactor service_instance_list_fetcher perm logic #3014

merged 1 commit into from
Oct 12, 2022

Conversation

philippthun
Copy link
Member

@philippthun philippthun commented Oct 10, 2022 •
edited
Loading

See #3003.

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

@jpalermo @MerricdeLauney @philippthun
Refactor service_instance_list_fetcher perm logic
4cb5241 
Rather than passing the list of space ids, pass a dataset that is
properly scoped.

Co-authored-by: Merric de Launey <[email protected]>
Signed-off-by: David Alvarado <[email protected]>
@philippthun philippthun force-pushed the service-instance-fetcher-refactor branch from bf87d39 to 4cb5241 Compare October 10, 2022 07:33
@philippthun philippthun marked this pull request as ready for review October 10, 2022 08:28
@philippthun
Copy link
Member Author

Hi @jpalermo, @MerricdeLauney, @dalvarado,

Sorry for interfering with your PR #3003.

With #3009 we added an exception to be raised if someone with admin access calls readable_space_guids_query or readable_org_guids_query as this would result in a query returning all spaces/orgs. If someone can read everything, this permission check simply does not make sense and should not be done. So I've reverted the revert of your PR and changed it so that the original if-else is kept.

@MerricdeLauney MerricdeLauney merged commit 0f5c0b9 into cloudfoundry:main Oct 12, 2022
will-gant pushed a commit to sap-contributions/cloud_controller_ng that referenced this pull request Oct 20, 2022
@philippthun @jpalermo
@MerricdeLauney @will-gant
Refactor service_instance_list_fetcher perm logic (cloudfoundry#3014)
8b03246 
Rather than passing the list of space ids, pass a dataset that is
properly scoped.

Signed-off-by: David Alvarado <[email protected]>
Co-authored-by: Joseph Palermo <[email protected]>
Co-authored-by: Merric de Launey <[email protected]>
MerricdeLauney added a commit that referenced this pull request Oct 25, 2022
@philippthun @jpalermo
@MerricdeLauney @bruce-ricard
Refactor service_instance_list_fetcher perm logic (#3014)
b58f561 
Rather than passing the list of space ids, pass a dataset that is
properly scoped.

Signed-off-by: David Alvarado <[email protected]>
Co-authored-by: Joseph Palermo <[email protected]>
Co-authored-by: Merric de Launey <[email protected]>
will-gant pushed a commit to sap-contributions/cloud_controller_ng that referenced this pull request Dec 16, 2022
@philippthun @jpalermo
@MerricdeLauney @will-gant
Refactor service_instance_list_fetcher perm logic (cloudfoundry#3014)
7cd4aa0 
Rather than passing the list of space ids, pass a dataset that is
properly scoped.

Signed-off-by: David Alvarado <[email protected]>
Co-authored-by: Joseph Palermo <[email protected]>
Co-authored-by: Merric de Launey <[email protected]>
@beyhan beyhan mentioned this pull request May 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@philippthun @cf-gitbot @MerricdeLauney @jpalermo