Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise an exception if user can read globally #3009

Conversation

kathap
Copy link
Contributor

@kathap kathap commented Oct 5, 2022

With #2986, #2995, #2997 no case is left where
readable_space_guids_query or readable_org_guids_query (permissions.rb) is called in an admin use case.

Therefore the select for all guids as admin user is not needed any more. Instead raise an exception if this query is called for admin users.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
With cloudfoundry#2986, cloudfoundry#2995, cloudfoundry#2997 no case is left where
readable_space_guids_query or readable_org_guids_query is called in an
admin use case. Therefore the select for all guids as admin user is not
needed any more. Instead raise an exception if this query is called for
admin users.
@kathap kathap marked this pull request as draft October 6, 2022 07:09
With cloudfoundry#2986, cloudfoundry#2995, cloudfoundry#2997, SELECT all guids for can_read_globally users is not called
anymore, the tests for readable_space_guids and readbale_org_guids
needed to be adjusted
@kathap kathap marked this pull request as ready for review October 6, 2022 08:26
@philippthun philippthun merged commit 4bf5f92 into cloudfoundry:main Oct 6, 2022
will-gant pushed a commit to sap-contributions/cloud_controller_ng that referenced this pull request Oct 20, 2022
With cloudfoundry#2986, cloudfoundry#2995, cloudfoundry#2997 no case is left where
readable_space_guids_query or readable_org_guids_query is called in an
admin use case. Therefore the select for all guids as admin user is not
needed any more. Instead raise an exception if this query is called for
admin users.
will-gant pushed a commit to sap-contributions/cloud_controller_ng that referenced this pull request Dec 16, 2022
With cloudfoundry#2986, cloudfoundry#2995, cloudfoundry#2997 no case is left where
readable_space_guids_query or readable_org_guids_query is called in an
admin use case. Therefore the select for all guids as admin user is not
needed any more. Instead raise an exception if this query is called for
admin users.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants