Raise an exception if user can read globally #3009
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #2986, #2995, #2997 no case is left where
readable_space_guids_query or readable_org_guids_query (permissions.rb) is called in an admin use case.
Therefore the select for all guids as admin user is not needed any more. Instead raise an exception if this query is called for admin users.
Links to any other associated PRs
Remove unnecessary db query as admin user for update_route_destinations #2986, Remove unnecessary db query as admin user for organization_quotas #2995, Reduce db queries for /organizations/:guid/domains #2997
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
main
branchI have run all the unit tests using
bundle exec rake
I have run CF Acceptance Tests