Adds support for cf-deployment Prometheus metrics #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the variable and manifest parameters that will be required for future consumption by code to support the `prom_scraper` Prometheus metrics scraper. Co-authored-by: Kenneth Lakin <[email protected]> Co-authored-by: David Alvarado <[email protected]>
MerricdeLauney
added a commit
to cloudfoundry/cloud_controller_ng
that referenced
this pull request
May 31, 2022
This change is dependent on cloudfoundry/cf-deployment#970 This reverts commit b278a04.
MerricdeLauney
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
May 31, 2022
This change is dependent on cloudfoundry/cf-deployment#970 This reverts commit 135f202, reversing changes made to 577b772.
MerricdeLauney
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
May 31, 2022
This change is dependent on cloudfoundry/cf-deployment#970 This reverts commit 352de44.
MerricdeLauney
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Jun 1, 2022
…metrics"" This reverts commit dd81216. Once cloudfoundry/cf-deployment#970 has been pulled in can we re-introduce this change
MerricdeLauney
added a commit
to cloudfoundry/cloud_controller_ng
that referenced
this pull request
Jun 1, 2022
This can be re-added once cloudfoundry/cf-deployment#970 is accepted This reverts commit 8415699.
This was referenced Jun 1, 2022
MerricdeLauney
added a commit
to cloudfoundry/cloud_controller_ng
that referenced
this pull request
Jun 28, 2022
This can be re-added once cloudfoundry/cf-deployment#970 is accepted This reverts commit 8415699.
MerricdeLauney
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Jun 28, 2022
…metrics"" This reverts commit dd81216. Once cloudfoundry/cf-deployment#970 has been pulled in can we re-introduce this change
3 tasks
will-gant
pushed a commit
to sap-contributions/cloud_controller_ng
that referenced
this pull request
Dec 16, 2022
This change is dependent on cloudfoundry/cf-deployment#970 This reverts commit b278a04.
will-gant
pushed a commit
to sap-contributions/cloud_controller_ng
that referenced
this pull request
Dec 16, 2022
This can be re-added once cloudfoundry/cf-deployment#970 is accepted This reverts commit 8415699.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this change about?
This commit adds the variable and manifest parameters that will be required for future consumption by code to support the
prom_scraperPrometheus metrics scraper.This PR is intended to support the work that will be merged in these two PRs: cloudfoundry/capi-release#240 and cloudfoundry/cloud_controller_ng#2781 . You probably should merge this PR after those two get merged in to their primary branches, but it shouldn't cause any trouble if you merged this PR in before one or both of those got merged in.
What customer problem is being addressed? Use customer persona to define the problem e.g. Alana is unable to...
I believe that it's true that most of the rest of CF uses prom_scraper to gather metrics and Cloud Controller / CAPI is one of the last holdouts. This work is required to support the changes made to CC / CAPI to eventually migrate from StatsD to prom_scraper.
Please provide any contextual information.
Here is the CAPI Team's Tracker story that tracks the work: https://www.pivotaltracker.com/story/show/181067519 . That story tracks this Cloud Controller Github Issue: cloudfoundry/cloud_controller_ng#2648
Has a cf-deployment including this change passed cf-acceptance-tests?
Does this PR introduce a breaking change? Please take a moment to read through the examples before answering the question.
How should this change be described in cf-deployment release notes?
Update cf-deployment manifest to support work to switch over to
prom_scraper. This supports work to address cloudfoundry/cloud_controller_ng#2648Does this PR introduce a new BOSH release into the base cf-deployment.yml manifest or any ops-files?
Does this PR make a change to an experimental or GA'd feature/component?
Please provide Acceptance Criteria for this change?
Acceptance criteria:
cfCLI, and targeting a running Cloud Foundry, run the following command, and wait for a minutes or two for output:What is the level of urgency for publishing this change?
This allows us to get a capi release that supports the old metrics we were using and new Prometheus based metrics
Tag your pair, your PM, and/or team!
cc @dalvarado @moleske @MerricdeLauney @tjvman @sethboyles