Adds support for prom_scraper metrics endpoint #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can remove the submodule update from this pr. There is a pipeline job that auto bumps the submodule for us |
10 tasks
* Nginx has been configured to listen on a second port (controlled by `cc.prom_metrics_server_tls_port`) and use a special set of certs (controlled by `cc.prom_scraper_tls`) to communicate with the `prom_scraper`. `prom_scraper` requires that the certificate of the server that it's scraping is signed with the same CA cert that every other endpoint in the deployment that it is scraping is signed with. So -rather than massively complicate configuration for our existing server configuration- we have decided to create a second server with its own configuration. Co-authored-by: Kenneth Lakin <[email protected]> Co-authored-by: Michael Oleske <[email protected]> Co-authored-by: David Alvarado <[email protected]> Co-authored-by: Merric de Launey <[email protected]>
klakin-pivotal
force-pushed
the
prometheus-metrics
branch
from
476b938 to
c92ded0
Compare
|
I think I've successfully removed the submodule update. |
MerricdeLauney
added a commit
that referenced
this pull request
May 31, 2022
This change is dependent on cloudfoundry/cf-deployment#970 This reverts commit 135f202, reversing changes made to 577b772.
MerricdeLauney
added a commit
that referenced
this pull request
Jun 1, 2022
…metrics"" This reverts commit dd81216. Once cloudfoundry/cf-deployment#970 has been pulled in can we re-introduce this change
MerricdeLauney
added a commit
that referenced
this pull request
Jun 28, 2022
…metrics"" This reverts commit dd81216. Once cloudfoundry/cf-deployment#970 has been pulled in can we re-introduce this change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR is dependent on this PR to
cloud_controller_ng: cloudfoundry/cloud_controller_ng#2781This PR contains the changes required to support the work in Cloud Controller NG's PR 2781, linked to above. You could merge this PR before 2781 is merged, and no harm would be done, but it would be best to not do that.
Notable technical details:
This commit adds two new Bosh Release configuration parameters:
cc.prom_metrics_server_tls_portandcc.prom_scraper_tls. They are fed to a new "server" in the release's nginx configuration. For more details, check out the commit message and code changes.I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
developbranchI have run CF Acceptance Tests on bosh lite
I have not run CF Acceptance Tests, but I have tested that the release can deploy multiple instances of the Dora CF App, both with cf-deployment and with VMware Tanzu.